Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Port long term scheduled transactions test from mono codebase #16179

Merged
merged 3 commits into from
Nov 1, 2024

Conversation

ibankov
Copy link
Contributor

@ibankov ibankov commented Oct 25, 2024

Port long term schedules tests from mono repo

Signed-off-by: ibankov <ivan.bankov@limechain.tech>
@ibankov ibankov added this to the v0.57 milestone Oct 25, 2024
@ibankov ibankov self-assigned this Oct 25, 2024
@ibankov ibankov requested review from a team as code owners October 25, 2024 11:34
@ibankov ibankov changed the title test: port long term schedule tests from mono test: Port long term scheduled transactions test from mono codebase Oct 25, 2024
Copy link

codacy-production bot commented Oct 25, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (ab86180) 99989 61890 61.90%
Head commit (a0875a8) 100040 (+51) 61924 (+34) 61.90% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#16179) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.35%. Comparing base (ab86180) to head (a0875a8).
Report is 34 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #16179      +/-   ##
=============================================
+ Coverage      58.30%   58.35%   +0.04%     
- Complexity     19929    19975      +46     
=============================================
  Files           2731     2735       +4     
  Lines         100172   100339     +167     
  Branches       10351    10365      +14     
=============================================
+ Hits           58406    58548     +142     
- Misses         38145    38164      +19     
- Partials        3621     3627       +6     

see 27 files with indirect coverage changes

Impacted file tree graph

Copy link

github-actions bot commented Oct 25, 2024

Node: HAPI Test (Restart) Results

9 files  1 errors  8 suites   7m 37s ⏱️
7 tests 7 ✅ 0 💤 0 ❌
8 runs  8 ✅ 0 💤 0 ❌

For more details on these parsing errors, see this check.

Results for commit a295a8b.

♻️ This comment has been updated with latest results.

@ibankov ibankov linked an issue Oct 28, 2024 that may be closed by this pull request
Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ty @ibankov !

Note that since @HapiTest's are no run with JUnit Jupiter, you can used the @Disabled annotation on them instead of commenting them out.

Signed-off-by: ibankov <ivan.bankov@limechain.tech>
@ibankov ibankov force-pushed the long_term_schedules_tests branch from 8c778c8 to a0875a8 Compare October 30, 2024 08:08
Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tyvm @ibankov !

@ibankov ibankov merged commit 4e7a92b into develop Nov 1, 2024
52 of 53 checks passed
@ibankov ibankov deleted the long_term_schedules_tests branch November 1, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port any long-term specific tests from mono code base.
2 participants