-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: HIP-904 Reject Tokens System Contract implementation #16118
Conversation
Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #16118 +/- ##
=============================================
+ Coverage 58.27% 58.32% +0.05%
- Complexity 19903 19943 +40
=============================================
Files 2730 2733 +3
Lines 100084 100237 +153
Branches 10337 10350 +13
=============================================
+ Hits 58325 58466 +141
- Misses 38136 38148 +12
Partials 3623 3623
|
Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
…ract # Conflicts: # hedera-node/hedera-smart-contract-service-impl/src/main/java/com/hedera/node/app/service/contract/impl/exec/gas/DispatchType.java # hedera-node/hedera-smart-contract-service-impl/src/main/java/com/hedera/node/app/service/contract/impl/exec/processors/HtsTranslatorsModule.java
…ract # Conflicts: # hedera-node/hedera-smart-contract-service-impl/src/main/java/com/hedera/node/app/service/contract/impl/exec/gas/DispatchType.java # hedera-node/hedera-smart-contract-service-impl/src/main/java/com/hedera/node/app/service/contract/impl/exec/processors/HtsTranslatorsModule.java # hedera-node/test-clients/src/main/java/com/hedera/services/bdd/spec/dsl/contracts/TokenRedirectContract.java
Node: HAPI Test (Restart) Results7 tests 1 ✅ 2m 6s ⏱️ For more details on these parsing errors and failures, see this check. Results for commit d80872a. |
...n/java/com/hedera/services/bdd/suites/contract/precompile/TokenRejectSystemContractTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except for the DispatchType thing, no other problems, but improvements could be made to unit tests similarly to the token cancel PR.
Gave the LGTM because I forgot about the DispatchType issue. That seems important enough to fix now?
...vice-impl/src/main/java/com/hedera/node/app/service/contract/impl/exec/gas/DispatchType.java
Outdated
Show resolved
Hide resolved
.../app/service/contract/impl/exec/systemcontracts/hts/rejecttokens/RejectTokensTranslator.java
Outdated
Show resolved
Hide resolved
...ervice/contract/impl/test/exec/systemcontracts/hts/rejecttokens/RejectTokensDecoderTest.java
Outdated
Show resolved
Hide resolved
...ode/app/service/contract/impl/exec/systemcontracts/hts/rejecttokens/RejectTokensDecoder.java
Show resolved
Hide resolved
...ervice/contract/impl/test/exec/systemcontracts/hts/rejecttokens/RejectTokensDecoderTest.java
Outdated
Show resolved
Hide resolved
...ice/contract/impl/test/exec/systemcontracts/hts/rejecttokens/RejectTokensTranslatorTest.java
Show resolved
Hide resolved
...ice/contract/impl/test/exec/systemcontracts/hts/rejecttokens/RejectTokensTranslatorTest.java
Show resolved
Hide resolved
…ract # Conflicts: # hedera-node/hedera-smart-contract-service-impl/src/main/java/com/hedera/node/app/service/contract/impl/exec/gas/DispatchType.java # hedera-node/hedera-smart-contract-service-impl/src/main/java/com/hedera/node/app/service/contract/impl/exec/processors/HtsTranslatorsModule.java # hedera-node/test-clients/src/main/java/com/hedera/services/bdd/spec/dsl/contracts/TokenRedirectContract.java
Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
Description:
This PR aims to implement the Reject Tokens system contract described in https://github.com/hashgraph/hedera-services/pull/15435/files?short_path=03ab1e7#diff-03ab1e73f0ded9a04739c3b1a68c13f779dce416cd2f7b6637b03d8e2e41e105
Related issue(s):
Fixes #15591
Notes for reviewer:
This feature is only enabled for dev and previewnet envs
Checklist