Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add services configuration design doc #16039

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

derektriley
Copy link
Contributor

Description:

Adds a markdown file explaining the purpose of the various *Config classes.

Related issue(s):

Fixes #16020

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@derektriley derektriley added this to the v0.56 milestone Oct 18, 2024
@derektriley derektriley self-assigned this Oct 18, 2024
@derektriley derektriley requested a review from a team October 18, 2024 14:08
@derektriley derektriley requested a review from a team as a code owner October 18, 2024 14:08
@derektriley derektriley requested a review from netopyr October 18, 2024 14:08
Copy link

codacy-production bot commented Oct 23, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+3.25% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (a0cc065) 99564 61377 61.65%
Head commit (ef6a159) 95496 (-4068) 61969 (+592) 64.89% (+3.25%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#16039) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.38%. Comparing base (a0cc065) to head (ef6a159).
Report is 86 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #16039      +/-   ##
=============================================
+ Coverage      58.05%   61.38%   +3.33%     
- Complexity     19765    20099     +334     
=============================================
  Files           2726     2600     -126     
  Lines          99747    96679    -3068     
  Branches       10295    10044     -251     
=============================================
+ Hits           57908    59349    +1441     
+ Misses         38233    33732    -4501     
+ Partials        3606     3598       -8     

see 486 files with indirect coverage changes

Impacted file tree graph

Signed-off-by: Derek Riley <derek.riley@swirldslabs.com>
Signed-off-by: Derek Riley <derek.riley@swirldslabs.com>
@derektriley derektriley force-pushed the 16020-services-config-design-doc branch from 602220d to 838354f Compare October 24, 2024 11:58
kimbor
kimbor previously approved these changes Oct 31, 2024
Signed-off-by: Derek Riley <derek.riley@swirldslabs.com>
Copy link
Contributor

@thomas-swirlds-labs thomas-swirlds-labs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks @derektriley

@derektriley derektriley merged commit 2601146 into develop Nov 7, 2024
49 of 50 checks passed
@derektriley derektriley deleted the 16020-services-config-design-doc branch November 7, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add design doc for Services configuration
3 participants