Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add InlinePcesWriter #16000

Merged
merged 7 commits into from
Oct 30, 2024
Merged

feat: Add InlinePcesWriter #16000

merged 7 commits into from
Oct 30, 2024

Conversation

timo0
Copy link
Member

@timo0 timo0 commented Oct 16, 2024

Fix #15605

Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
@timo0 timo0 added this to the v0.56 milestone Oct 16, 2024
@timo0 timo0 self-assigned this Oct 16, 2024
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 62.23776% with 54 lines in your changes missing coverage. Please review.

Project coverage is 58.82%. Comparing base (9780e5f) to head (0e2b13b).
Report is 78 commits behind head on develop.

Files with missing lines Patch % Lines
...platform/event/preconsensus/DefaultPcesWriter.java 0.00% 29 Missing ⚠️
.../platform/event/preconsensus/CommonPcesWriter.java 83.51% 10 Missing and 5 partials ⚠️
...rm/event/preconsensus/DefaultInlinePcesWriter.java 56.52% 8 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #16000      +/-   ##
=============================================
+ Coverage      58.22%   58.82%   +0.60%     
+ Complexity     21712    20120    -1592     
=============================================
  Files           2801     2737      -64     
  Lines         109857   100326    -9531     
  Branches       11229    10358     -871     
=============================================
- Hits           63965    59020    -4945     
+ Misses         42024    37633    -4391     
+ Partials        3868     3673     -195     
Files with missing lines Coverage Δ
...rm/event/preconsensus/DefaultInlinePcesWriter.java 56.52% <56.52%> (ø)
.../platform/event/preconsensus/CommonPcesWriter.java 83.51% <83.51%> (ø)
...platform/event/preconsensus/DefaultPcesWriter.java 0.00% <0.00%> (-81.60%) ⬇️

... and 456 files with indirect coverage changes

Impacted file tree graph

Copy link

codacy-production bot commented Oct 16, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.44% (target: -1.00%) 67.13%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (9780e5f) 109674 67724 61.75%
Head commit (0e2b13b) 99230 (-10444) 61710 (-6014) 62.19% (+0.44%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#16000) 143 96 67.13%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@timo0 timo0 requested a review from lpetrovic05 October 16, 2024 21:19
@timo0 timo0 marked this pull request as ready for review October 16, 2024 21:19
@timo0 timo0 requested a review from a team as a code owner October 16, 2024 21:19
@lpetrovic05
Copy link
Member

I think there should be at least some tests for the new class

Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
@timo0 timo0 requested a review from lpetrovic05 October 22, 2024 14:01
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
@lpetrovic05
Copy link
Member

I think there isn't any test for the inline PCES writer

Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
@timo0 timo0 requested a review from lpetrovic05 October 25, 2024 12:37
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
@timo0 timo0 requested a review from a team as a code owner October 28, 2024 13:33
@timo0 timo0 requested a review from hendrikebbers October 28, 2024 13:33
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
@timo0 timo0 merged commit 2c30a3a into develop Oct 30, 2024
49 of 50 checks passed
@timo0 timo0 deleted the inline-pces-writer branch October 30, 2024 19:29
Evdokia-Georgieva pushed a commit that referenced this pull request Oct 31, 2024
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create new inline PCES Writer component
2 participants