-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add InlinePcesWriter #16000
feat: Add InlinePcesWriter #16000
Conversation
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #16000 +/- ##
=============================================
+ Coverage 58.22% 58.82% +0.60%
+ Complexity 21712 20120 -1592
=============================================
Files 2801 2737 -64
Lines 109857 100326 -9531
Branches 11229 10358 -871
=============================================
- Hits 63965 59020 -4945
+ Misses 42024 37633 -4391
+ Partials 3868 3673 -195
|
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
...ds-platform-core/src/main/java/com/swirlds/platform/event/preconsensus/CommonPcesWriter.java
Outdated
Show resolved
Hide resolved
...ds-platform-core/src/main/java/com/swirlds/platform/event/preconsensus/CommonPcesWriter.java
Outdated
Show resolved
Hide resolved
...ds-platform-core/src/main/java/com/swirlds/platform/event/preconsensus/CommonPcesWriter.java
Outdated
Show resolved
Hide resolved
...ds-platform-core/src/main/java/com/swirlds/platform/event/preconsensus/CommonPcesWriter.java
Outdated
Show resolved
Hide resolved
...ds-platform-core/src/main/java/com/swirlds/platform/event/preconsensus/CommonPcesWriter.java
Outdated
Show resolved
Hide resolved
...form-core/src/main/java/com/swirlds/platform/event/preconsensus/DefaultInlinePcesWriter.java
Outdated
Show resolved
Hide resolved
...ds-platform-core/src/main/java/com/swirlds/platform/event/preconsensus/CommonPcesWriter.java
Outdated
Show resolved
Hide resolved
...ds-platform-core/src/main/java/com/swirlds/platform/event/preconsensus/InlinePcesWriter.java
Outdated
Show resolved
Hide resolved
I think there should be at least some tests for the new class |
...form-core/src/main/java/com/swirlds/platform/event/preconsensus/DefaultInlinePcesWriter.java
Outdated
Show resolved
Hide resolved
...form-core/src/main/java/com/swirlds/platform/event/preconsensus/DefaultInlinePcesWriter.java
Outdated
Show resolved
Hide resolved
...form-core/src/main/java/com/swirlds/platform/event/preconsensus/DefaultInlinePcesWriter.java
Outdated
Show resolved
Hide resolved
I think there isn't any test for the inline PCES writer |
...form-core/src/main/java/com/swirlds/platform/event/preconsensus/DefaultInlinePcesWriter.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
...-core/src/test/java/com/swirlds/platform/event/preconsensus/DefaultInlinePcesWriterTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
Fix #15605