Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: run entrypoint as s6 supervised service #15944

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

matteriben
Copy link
Contributor

Description:
Run entrypoint.sh as s6 supervised service to provide a structured path to perform setup/teardown through s6 supervision.

Related issue(s):

Fixes #15942

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@matteriben matteriben self-assigned this Oct 10, 2024
@matteriben matteriben requested review from a team as code owners October 10, 2024 02:56
@matteriben matteriben requested a review from a team October 10, 2024 02:56
@matteriben matteriben requested a review from a team as a code owner October 10, 2024 02:56
Copy link

codacy-production bot commented Oct 10, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (61bf732) 109348 67499 61.73%
Head commit (556620e) 109348 (+0) 67499 (+0) 61.73% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#15944) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.19%. Comparing base (61bf732) to head (556620e).
Report is 78 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             develop   #15944   +/-   ##
==========================================
  Coverage      58.19%   58.19%           
  Complexity     21642    21642           
==========================================
  Files           2791     2791           
  Lines         109531   109531           
  Branches       11204    11204           
==========================================
  Hits           63746    63746           
  Misses         41922    41922           
  Partials        3863     3863           

Impacted file tree graph

@matteriben matteriben marked this pull request as draft October 10, 2024 03:14
@matteriben matteriben force-pushed the 15942-run-entrypoint-as-s6-supervised-service branch from 818a5f5 to 7dfd8da Compare October 11, 2024 06:42
@matteriben matteriben added this to the v0.56 milestone Oct 11, 2024
@matteriben matteriben force-pushed the 15942-run-entrypoint-as-s6-supervised-service branch 3 times, most recently from bfdcbd4 to 515940a Compare October 11, 2024 07:33
@matteriben matteriben marked this pull request as ready for review October 11, 2024 07:34
rbarkerSL
rbarkerSL previously approved these changes Oct 11, 2024
@matteriben matteriben marked this pull request as draft October 11, 2024 17:22
@matteriben matteriben force-pushed the 15942-run-entrypoint-as-s6-supervised-service branch 2 times, most recently from aad400f to 678fbe0 Compare October 12, 2024 05:32
@matteriben matteriben marked this pull request as ready for review October 12, 2024 06:42
Signed-off-by: Matt Riben <matt.riben@swirldslabs.com>
@matteriben matteriben force-pushed the 15942-run-entrypoint-as-s6-supervised-service branch from 678fbe0 to 556620e Compare October 15, 2024 15:04
@matteriben matteriben merged commit e178e9f into develop Oct 30, 2024
50 checks passed
@matteriben matteriben deleted the 15942-run-entrypoint-as-s6-supervised-service branch October 30, 2024 01:58
Evdokia-Georgieva pushed a commit that referenced this pull request Oct 31, 2024
Signed-off-by: Matt Riben <matt.riben@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run entrypoint.sh in deterministic image as supervised service under s6
4 participants