-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cherry pick fix permissions for upgrade test (#10779) #10809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffreyDallas
requested review from
netopyr,
Neeharika-Sompalli,
jeromy-cannon and
tomzhenghedera
January 8, 2024 15:36
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/0.46 #10809 +/- ##
==================================================
- Coverage 62.79% 62.79% -0.01%
Complexity 30928 30928
==================================================
Files 3380 3380
Lines 136654 136654
Branches 14242 14242
==================================================
- Hits 85815 85814 -1
- Misses 47444 47445 +1
Partials 3395 3395 ☔ View full report in Codecov by Sentry. |
jeromy-cannon
approved these changes
Jan 8, 2024
Neeharika-Sompalli
approved these changes
Jan 9, 2024
nathanklick
approved these changes
Jan 9, 2024
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com> Co-authored-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com> Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
JeffreyDallas
force-pushed
the
0.46-cherry-pick-fix-upgrade-test
branch
from
January 9, 2024 19:37
6dfcdc0
to
41d3861
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Test result
https://swirldslabs.slack.com/archives/C03G7CBJJ06/p1704648924328729