fix: Add a feature flag for token balances and token relationships and enable them

[Neeharika-Sompalli]

Reverts this PR #10149

Adds a feature flag tokens.balancesInQueries.enabled to enable/disable the token balances and token relationships information to be returned in queries

[github-actions]

Node: HAPI Test (Token) Results

189 tests  ±0   189 ✔️ ±0   16m 39s ⏱️ +27s
  13 suites ±0       0 💤 ±0 
  13 files   ±0       0 ❌ ±0 

Results for commit fb32cb1. ± Comparison against base commit 9f2841b.

♻️ This comment has been updated with latest results.

[github-actions]

Node: HAPI Test (Crypto) Results

211 tests  ±0   205 ✔️ ±0   18m 15s ⏱️ +34s
  22 suites ±0       6 💤 ±0 
  22 files   ±0       0 ❌ ±0 

Results for commit fb32cb1. ± Comparison against base commit 9f2841b.

♻️ This comment has been updated with latest results.

[github-actions]

Node: Unit Test Results

    2 291 files  ±0      2 291 suites  ±0   54m 51s ⏱️ + 3m 52s
118 617 tests +1  118 582 ✔️ +1  35 💤 ±0  0 ❌ ±0 
127 034 runs  +1  126 999 ✔️ +1  35 💤 ±0  0 ❌ ±0 

Results for commit fb32cb1. ± Comparison against base commit 9f2841b.

♻️ This comment has been updated with latest results.

[codecov]

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (0ca35f5) 62.80% compared to head (fb32cb1) 62.82%.
Report is 1 commits behind head on develop.

Files	Patch %	Lines
...contract/impl/handlers/ContractGetInfoHandler.java	0.00%	9 Missing ⚠️
.../impl/handlers/CryptoGetAccountBalanceHandler.java	85.00%	0 Missing and 3 partials ⚠️
...app/service/mono/context/primitives/StateView.java	75.00%	0 Missing and 2 partials ⚠️
...no/context/properties/GlobalDynamicProperties.java	50.00%	1 Missing ⚠️
...ken/impl/handlers/CryptoGetAccountInfoHandler.java	83.33%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##             develop   #10638      +/-   ##
=============================================
+ Coverage      62.80%   62.82%   +0.01%     
- Complexity     30891    30901      +10     
=============================================
  Files           3376     3376              
  Lines         136345   136413      +68     
  Branches       14207    14218      +11     
=============================================
+ Hits           85634    85698      +64     
+ Misses         47312    47311       -1     
- Partials        3399     3404       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Node: E2E Test Results

    1 files  ±    0      1 suites  ±0   21m 48s ⏱️ + 21m 48s
311 tests +310  311 ✔️ +311  0 💤 ±0  0 ❌  - 1 
333 runs  +332  333 ✔️ +333  0 💤 ±0  0 ❌  - 1 

Results for commit fb32cb1. ± Comparison against base commit 9f2841b.

This pull request removes 1 and adds 311 tests. Note that renamed tests count towards both.

EndToEndTests ‑ initializationError

EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateADDRESS_BOOK
EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateNODE_DETAILS
EndToEndTests ‑ AccountsGetPayerRecordsIfSoConfigured
EndToEndTests ‑ Acct57CanMakeSmallChanges
EndToEndTests ‑ Acct57CantMakeLargeChanges
EndToEndTests ‑ AddingSignaturesToExecutedTxFails
EndToEndTests ‑ AddingSignaturesToExecutedTxFailsWithLongTermEnabled
EndToEndTests ‑ AddingSignaturesToNonExistingTxFails
EndToEndTests ‑ AddingSignaturesToNonExistingTxFailsWithLongTermEnabled
EndToEndTests ‑ AddressAliasIdFuzzing
…

♻️ This comment has been updated with latest results.

[github-actions]

Node: HAPI Test (Time Consuming) Results

21 tests  ±0     9 ✔️ ±0   24m 51s ⏱️ -8s
  2 suites ±0   12 💤 ±0 
  2 files   ±0     0 ❌ ±0 

Results for commit fb32cb1. ± Comparison against base commit 9f2841b.

♻️ This comment has been updated with latest results.

[github-actions]

Node: HAPI Test (Misc) Results

420 tests  ±0   347 ✔️ ±0   28m 4s ⏱️ -46s
  73 suites ±0     73 💤 ±0 
  73 files   ±0       0 ❌ ±0 

Results for commit fb32cb1. ± Comparison against base commit 9f2841b.

♻️ This comment has been updated with latest results.

[github-actions]

Node: Integration Test Results

280 tests  ±0   280 ✔️ ±0   28m 30s ⏱️ -1s
    5 suites ±0       0 💤 ±0 
    5 files   ±0       0 ❌ ±0 

Results for commit fb32cb1. ± Comparison against base commit 9f2841b.

♻️ This comment has been updated with latest results.

[github-actions]

Node: HAPI Test (Smart Contract) Results

412 tests  ±0   399 ✔️ ±0   49m 52s ⏱️ + 1m 2s
  55 suites ±0     13 💤 ±0 
  55 files   ±0       0 ❌ ±0 

Results for commit fb32cb1. ± Comparison against base commit 9f2841b.

♻️ This comment has been updated with latest results.

[tinker-michaelj]

LGTM, tyvm @Neeharika-Sompalli !

[tinker-michaelj]

Node software changes LGTM 💯 , but here we will end up with a repeated list of tokenRelationships when the feature flag is on and the GetContractInfo query is returning tokenRelationships again.

Instead we need,

            actualInfo = actualInfo.toBuilder()
                    .clearTokenRelationships()
                    .addAllTokenRelationships(actualTokenRels)
                    .build();

to ensure our expectations use only the getAccountDetails response no matter the feature flag.

[Neeharika-Sompalli]

actualInfo = actualInfo.toBuilder()
.clearTokenRelationships()
.addAllTokenRelationships(actualTokenRels)
.build();

Ah yes. Thank you very much @tinker-michaelj 🙏

[tinker-michaelj]

LGTM!