-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: DuplicateManagementTest
tests
#10622
Conversation
Signed-off-by: dikel <dikelito@tutamail.com>
Signed-off-by: dikel <dikelito@tutamail.com>
Signed-off-by: dikel <dikelito@tutamail.com>
Signed-off-by: dikel <dikelito@tutamail.com>
Signed-off-by: dikel <dikelito@tutamail.com>
…fiable Signed-off-by: dikel <dikelito@tutamail.com>
Node: E2E Test Results 1 files ± 0 1 suites ±0 22m 41s ⏱️ + 22m 41s Results for commit bfdd5dc. ± Comparison against base commit 0f965a4. This pull request removes 1 and adds 311 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #10622 +/- ##
=============================================
+ Coverage 62.79% 62.82% +0.02%
- Complexity 30884 30902 +18
=============================================
Files 3375 3376 +1
Lines 136336 136413 +77
Branches 14206 14218 +12
=============================================
+ Hits 85615 85697 +82
+ Misses 47326 47313 -13
- Partials 3395 3403 +8 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description:
Fixes
usesUnclassifiableIfNoClassifiableAvailable
andhasExpectedDuplicates
tests inDuplicateManagementTest
Related issue(s):
Fixes #9502
Notes for reviewer:
Currently the first unchecked submit in
hasExpectedDuplicates
fails withBUSY
because we don't haveThrottleReqsManager
for unchecked submits. If we change theThrottleAccumulator
such that it is not throttling the transaction it passes instead of failing withNOT_SUPPORTED
.Checklist