Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DuplicateManagementTest tests #10622

Merged
merged 9 commits into from
Dec 25, 2023

Conversation

dikel
Copy link
Contributor

@dikel dikel commented Dec 22, 2023

Description:
Fixes usesUnclassifiableIfNoClassifiableAvailable and hasExpectedDuplicates tests in DuplicateManagementTest

Related issue(s):

Fixes #9502

Notes for reviewer:
Currently the first unchecked submit in hasExpectedDuplicates fails with BUSY because we don't have ThrottleReqsManager for unchecked submits. If we change the ThrottleAccumulator such that it is not throttling the transaction it passes instead of failing with NOT_SUPPORTED.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: dikel <dikelito@tutamail.com>
Signed-off-by: dikel <dikelito@tutamail.com>
Signed-off-by: dikel <dikelito@tutamail.com>
Signed-off-by: dikel <dikelito@tutamail.com>
Signed-off-by: dikel <dikelito@tutamail.com>
…fiable

Signed-off-by: dikel <dikelito@tutamail.com>
@dikel dikel added Limechain Work planned for the LimeChain team Modularization Issues or PRs related to modularization labels Dec 22, 2023
@dikel dikel self-assigned this Dec 22, 2023
@dikel dikel requested a review from a team December 22, 2023 07:28
@dikel dikel requested a review from a team as a code owner December 22, 2023 07:28
@dikel dikel requested a review from mhess-swl December 22, 2023 07:28
Copy link

github-actions bot commented Dec 22, 2023

Node: HAPI Test (Token) Results

189 tests  ±0   189 ✔️ ±0   17m 48s ⏱️ + 1m 18s
  13 suites ±0       0 💤 ±0 
  13 files   ±0       0 ±0 

Results for commit bfdd5dc. ± Comparison against base commit 0f965a4.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 22, 2023

Node: HAPI Test (Crypto) Results

211 tests  ±0   205 ✔️ ±0   17m 43s ⏱️ +59s
  22 suites ±0       6 💤 ±0 
  22 files   ±0       0 ±0 

Results for commit bfdd5dc. ± Comparison against base commit 0f965a4.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 22, 2023

Node: Unit Test Results

    2 291 files  ±0      2 291 suites  ±0   55m 36s ⏱️ + 9m 43s
118 617 tests +4  118 582 ✔️ +4  35 💤 ±0  0 ±0 
127 034 runs  +4  126 999 ✔️ +4  35 💤 ±0  0 ±0 

Results for commit bfdd5dc. ± Comparison against base commit 0f965a4.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 22, 2023

Node: E2E Test Results

    1 files  ±    0      1 suites  ±0   22m 41s ⏱️ + 22m 41s
311 tests +310  311 ✔️ +311  0 💤 ±0  0  - 1 
333 runs  +332  333 ✔️ +333  0 💤 ±0  0  - 1 

Results for commit bfdd5dc. ± Comparison against base commit 0f965a4.

This pull request removes 1 and adds 311 tests. Note that renamed tests count towards both.
EndToEndTests ‑ initializationError
EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateADDRESS_BOOK
EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateNODE_DETAILS
EndToEndTests ‑ AccountsGetPayerRecordsIfSoConfigured
EndToEndTests ‑ Acct57CanMakeSmallChanges
EndToEndTests ‑ Acct57CantMakeLargeChanges
EndToEndTests ‑ AddingSignaturesToExecutedTxFails
EndToEndTests ‑ AddingSignaturesToExecutedTxFailsWithLongTermEnabled
EndToEndTests ‑ AddingSignaturesToNonExistingTxFails
EndToEndTests ‑ AddingSignaturesToNonExistingTxFailsWithLongTermEnabled
EndToEndTests ‑ AddressAliasIdFuzzing
…

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Dec 22, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (0f965a4) 62.79% compared to head (bfdd5dc) 62.82%.
Report is 7 commits behind head on develop.

Files Patch % Lines
...dera/node/app/workflows/handle/HandleWorkflow.java 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop   #10622      +/-   ##
=============================================
+ Coverage      62.79%   62.82%   +0.02%     
- Complexity     30884    30902      +18     
=============================================
  Files           3375     3376       +1     
  Lines         136336   136413      +77     
  Branches       14206    14218      +12     
=============================================
+ Hits           85615    85697      +82     
+ Misses         47326    47313      -13     
- Partials        3395     3403       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 22, 2023

Node: HAPI Test (Time Consuming) Results

21 tests  ±0     9 ✔️ ±0   24m 55s ⏱️ -33s
  2 suites ±0   12 💤 ±0 
  2 files   ±0     0 ±0 

Results for commit bfdd5dc. ± Comparison against base commit 0f965a4.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 22, 2023

Node: HAPI Test (Misc) Results

420 tests  ±0   349 ✔️ +2   28m 29s ⏱️ + 1m 58s
  73 suites ±0     71 💤  - 2 
  73 files   ±0       0 ±0 

Results for commit bfdd5dc. ± Comparison against base commit 0f965a4.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 22, 2023

Node: Integration Test Results

280 tests  ±0   280 ✔️ ±0   28m 12s ⏱️ -10s
    5 suites ±0       0 💤 ±0 
    5 files   ±0       0 ±0 

Results for commit bfdd5dc. ± Comparison against base commit 0f965a4.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 22, 2023

Node: HAPI Test (Smart Contract) Results

412 tests  ±0   399 ✔️ +3   51m 52s ⏱️ + 4m 56s
  55 suites ±0     13 💤  - 2 
  55 files   ±0       0  - 1 

Results for commit bfdd5dc. ± Comparison against base commit 0f965a4.

♻️ This comment has been updated with latest results.

Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tinker-michaelj tinker-michaelj merged commit 85d1006 into develop Dec 25, 2023
37 checks passed
@tinker-michaelj tinker-michaelj deleted the 09502-fix-duplicate-management-test branch December 25, 2023 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Limechain Work planned for the LimeChain team Modularization Issues or PRs related to modularization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix DuplicateManagementTest
2 participants