-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add broken up version of PCES classes #10595
Conversation
Signed-off-by: Austin Littley <austin@swirldslabs.com>
Signed-off-by: Austin Littley <austin@swirldslabs.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #10595 +/- ##
==========================================
Coverage ? 62.85%
Complexity ? 30888
==========================================
Files ? 3374
Lines ? 136220
Branches ? 14194
==========================================
Hits ? 85616
Misses ? 47212
Partials ? 3392 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, LGTM other than a few nitpicks. Lol, git blame is going to make people start coming to you when the PCES breaks. 😄
...latform-core/src/main/java/com/swirlds/platform/event/preconsensus/EventDurabilityNexus.java
Show resolved
Hide resolved
...k/swirlds-platform-core/src/main/java/com/swirlds/platform/event/preconsensus/PcesFiles.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Austin Littley <austin@swirldslabs.com>
PreconsensusEventWriter
to new framework #10024The new files in this PR are a broken-up rework of the existing PCES files. The new files aren't used yet, and the old files are left alone.
diagram