-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Improved error message and for properties file missing #10591
fix: Improved error message and for properties file missing #10591
Conversation
Signed-off-by: Thomas Moran <152873392+thomas-swirlds-labs@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #10591 +/- ##
==========================================
Coverage ? 63.03%
Complexity ? 30859
==========================================
Files ? 3363
Lines ? 135631
Branches ? 14127
==========================================
Hits ? 85496
Misses ? 46747
Partials ? 3388 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tyvm @thomas-swirlds-labs 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 🎉 .. Thanks @thomas-swirlds-labs
Description:
This PR modifies PropertyConfigSource in order to handle the case when the resource file does not exist
Includes a new Unit Test class for supporting the change.
Related issue(s):
Fixes #9689
Notes for reviewer:
Checklist