chore: avoid confusing INSUFFICIENT_PAYER_BALANCE warnings
#10578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
INSUFFICIENT_PAYER_BALANCE warningsINSUFFICIENT_PAYER_BALANCE warnings
mhess-swl
approved these changes
Dec 19, 2023
Node: E2E Test Results 1 files ± 0 1 suites ±0 23m 1s ⏱️ + 23m 1s Results for commit a30c827. ± Comparison against base commit e2ef0f6. This pull request removes 1 and adds 311 tests. Note that renamed tests count towards both. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #10578 +/- ##
==========================================
Coverage ? 63.04%
Complexity ? 30837
==========================================
Files ? 3363
Lines ? 135487
Branches ? 14096
==========================================
Hits ? 85414
Misses ? 46712
Partials ? 3361 ☔ View full report in Codecov by Sentry. |
thomas-swirlds-labs
pushed a commit
that referenced
this pull request
Dec 20, 2023
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com> Signed-off-by: Thomas Moran <152873392+thomas-swirlds-labs@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
CannotDeleteSystemEntitiesSuite.INSUFFICIENT_PAYER_BALANCEwarnings in CI; even though these are not treated as test failures, they look that way.