Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sync ppm optimization #10569

Merged
merged 9 commits into from
Dec 21, 2023
Merged

fix: sync ppm optimization #10569

merged 9 commits into from
Dec 21, 2023

Conversation

cody-littley
Copy link
Contributor

Closes #10307

Cody Littley added 3 commits December 5, 2023 16:36
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley cody-littley added this to the v0.46 milestone Dec 19, 2023
@cody-littley cody-littley self-assigned this Dec 19, 2023
Copy link

github-actions bot commented Dec 19, 2023

Node: HAPI Test (Token) Results

189 tests  ±0   189 ✔️ ±0   17m 7s ⏱️ -7s
  13 suites ±0       0 💤 ±0 
  13 files   ±0       0 ±0 

Results for commit 70022cf. ± Comparison against base commit 220fdba.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 19, 2023

Node: HAPI Test (Crypto) Results

211 tests  ±0   205 ✔️ ±0   16m 5s ⏱️ - 1m 31s
  22 suites ±0       6 💤 ±0 
  22 files   ±0       0 ±0 

Results for commit 70022cf. ± Comparison against base commit 220fdba.

♻️ This comment has been updated with latest results.

@cody-littley cody-littley changed the title 10307 sync ppm optimization fix: sync ppm optimization Dec 19, 2023
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Copy link

github-actions bot commented Dec 19, 2023

Node: Unit Test Results

    2 290 files  ±0      2 290 suites  ±0   53m 11s ⏱️ + 5m 9s
118 607 tests ±0  118 573 ✔️ ±0  34 💤 ±0  0 ±0 
127 024 runs  ±0  126 990 ✔️ ±0  34 💤 ±0  0 ±0 

Results for commit 70022cf. ± Comparison against base commit 220fdba.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 19, 2023

Node: E2E Test Results

    1 files  ±    0      1 suites  ±0   23m 8s ⏱️ + 23m 8s
311 tests +310  311 ✔️ +311  0 💤 ±0  0  - 1 
333 runs  +332  333 ✔️ +333  0 💤 ±0  0  - 1 

Results for commit 70022cf. ± Comparison against base commit 220fdba.

This pull request removes 1 and adds 311 tests. Note that renamed tests count towards both.
EndToEndTests ‑ initializationError
EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateADDRESS_BOOK
EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateNODE_DETAILS
EndToEndTests ‑ AccountsGetPayerRecordsIfSoConfigured
EndToEndTests ‑ Acct57CanMakeSmallChanges
EndToEndTests ‑ Acct57CantMakeLargeChanges
EndToEndTests ‑ AddingSignaturesToExecutedTxFails
EndToEndTests ‑ AddingSignaturesToExecutedTxFailsWithLongTermEnabled
EndToEndTests ‑ AddingSignaturesToNonExistingTxFails
EndToEndTests ‑ AddingSignaturesToNonExistingTxFailsWithLongTermEnabled
EndToEndTests ‑ AddressAliasIdFuzzing
…

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 19, 2023

Node: HAPI Test (Time Consuming) Results

21 tests  ±0     9 ✔️ ±0   24m 45s ⏱️ -1s
  2 suites ±0   12 💤 ±0 
  2 files   ±0     0 ±0 

Results for commit 70022cf. ± Comparison against base commit 220fdba.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: 67 lines in your changes are missing coverage. Please review.

Comparison is base (220fdba) 63.05% compared to head (70022cf) 63.02%.
Report is 1 commits behind head on develop.

Files Patch % Lines
...m/gossip/shadowgraph/LatestEventTipsetTracker.java 0.00% 18 Missing ⚠️
...ain/java/com/swirlds/platform/SwirldsPlatform.java 0.00% 9 Missing ⚠️
...rm/gossip/shadowgraph/ShadowGraphSynchronizer.java 0.00% 9 Missing ⚠️
...swirlds/platform/components/LinkedEventIntake.java 0.00% 8 Missing ⚠️
...swirlds/platform/gossip/shadowgraph/SyncUtils.java 0.00% 6 Missing ⚠️
...a/com/swirlds/platform/components/EventIntake.java 0.00% 5 Missing ⚠️
...m/gossip/shadowgraph/ShadowGraphEventObserver.java 0.00% 5 Missing ⚠️
...irlds/platform/gossip/shadowgraph/ShadowGraph.java 0.00% 4 Missing ⚠️
...java/com/swirlds/platform/metrics/SyncMetrics.java 50.00% 3 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop   #10569      +/-   ##
=============================================
- Coverage      63.05%   63.02%   -0.03%     
+ Complexity     30883    30879       -4     
=============================================
  Files           3367     3368       +1     
  Lines         135774   135823      +49     
  Branches       14139    14149      +10     
=============================================
- Hits           85608    85605       -3     
- Misses         46773    46822      +49     
- Partials        3393     3396       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 19, 2023

Node: HAPI Test (Misc) Results

420 tests  ±0   347 ✔️ ±0   27m 1s ⏱️ - 1m 6s
  73 suites ±0     73 💤 ±0 
  73 files   ±0       0 ±0 

Results for commit 70022cf. ± Comparison against base commit 220fdba.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 19, 2023

Node: Integration Test Results

280 tests  ±0   280 ✔️ ±0   28m 47s ⏱️ +15s
    5 suites ±0       0 💤 ±0 
    5 files   ±0       0 ±0 

Results for commit 70022cf. ± Comparison against base commit 220fdba.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 19, 2023

Node: HAPI Test (Smart Contract) Results

412 tests  ±0   396 ✔️  - 1   45m 54s ⏱️ - 1m 52s
  55 suites ±0     15 💤 ±0 
  55 files   ±0       1 +1 

For more details on these failures, see this check.

Results for commit 70022cf. ± Comparison against base commit 220fdba.

♻️ This comment has been updated with latest results.

@cody-littley cody-littley marked this pull request as ready for review December 19, 2023 20:29
@cody-littley cody-littley requested review from a team as code owners December 19, 2023 20:29
@cody-littley cody-littley requested a review from timo0 December 19, 2023 20:29
Signed-off-by: Cody Littley <cody@swirldslabs.com>
litt3
litt3 previously approved these changes Dec 20, 2023
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley cody-littley merged commit 93cd4e5 into develop Dec 21, 2023
34 of 37 checks passed
@cody-littley cody-littley deleted the 10307-syncPPM-optimization branch December 21, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sync++- Performance Optimization
4 participants