Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add test setting to force ignore PCES signatures #10538

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

litt3
Copy link
Contributor

@litt3 litt3 commented Dec 15, 2023

Signed-off-by: Austin Littley <austin@swirldslabs.com>
@litt3 litt3 added this to the v0.45 milestone Dec 15, 2023
@litt3 litt3 self-assigned this Dec 15, 2023
@litt3 litt3 marked this pull request as ready for review December 15, 2023 15:09
@litt3 litt3 requested a review from a team as a code owner December 15, 2023 15:09
Copy link

Node: HAPI Test (Crypto) Results

211 tests   204 ✔️  17m 15s ⏱️
  22 suites      7 💤
  22 files        0

Results for commit 4d57b02.

Copy link

Node: HAPI Test (Token) Results

189 tests   189 ✔️  19m 26s ⏱️
  13 suites      0 💤
  13 files        0

Results for commit 4d57b02.

Copy link

Node: Unit Test Results

    2 293 files  ±0      2 293 suites  ±0   52m 17s ⏱️ + 1m 53s
118 445 tests ±0  118 411 ✔️ ±0  34 💤 ±0  0 ±0 
126 862 runs  ±0  126 828 ✔️ ±0  34 💤 ±0  0 ±0 

Results for commit 4d57b02. ± Comparison against base commit e727601.

Copy link

Node: E2E Test Results

    1 files      1 suites   24m 2s ⏱️
311 tests 311 ✔️ 0 💤 0
333 runs  333 ✔️ 0 💤 0

Results for commit 4d57b02.

Copy link

Node: HAPI Test (Time Consuming) Results

21 tests     9 ✔️  25m 20s ⏱️
  2 suites  12 💤
  2 files      0

Results for commit 4d57b02.

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Attention: 26 lines in your changes are missing coverage. Please review.

Comparison is base (3a99e37) 63.01% compared to head (4d57b02) 62.99%.
Report is 3 commits behind head on develop.

Files Patch % Lines
...ain/java/com/swirlds/platform/SwirldsPlatform.java 0.00% 15 Missing ⚠️
...rlds/platform/components/SavedStateController.java 0.00% 8 Missing ⚠️
...ponents/state/DefaultStateManagementComponent.java 50.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop   #10538      +/-   ##
=============================================
- Coverage      63.01%   62.99%   -0.02%     
+ Complexity     30824    30819       -5     
=============================================
  Files           3363     3363              
  Lines         135414   135416       +2     
  Branches       14092    14090       -2     
=============================================
- Hits           85325    85309      -16     
- Misses         46730    46752      +22     
+ Partials        3359     3355       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Node: Integration Test Results

278 tests  ±0   278 ✔️ ±0   27m 0s ⏱️ +18s
    5 suites ±0       0 💤 ±0 
    5 files   ±0       0 ±0 

Results for commit 4d57b02. ± Comparison against base commit e727601.

Copy link

Node: HAPI Test (Smart Contract) Results

398 tests   366 ✔️  46m 42s ⏱️
  55 suites    32 💤
  55 files        0

Results for commit 4d57b02.

@litt3 litt3 merged commit ae24696 into develop Dec 15, 2023
40 of 42 checks passed
@litt3 litt3 deleted the 10537-force-ignore-pces-sigs branch December 15, 2023 16:52
litt3 added a commit that referenced this pull request Dec 15, 2023
Signed-off-by: Austin Littley <austin@swirldslabs.com>
litt3 added a commit that referenced this pull request Dec 15, 2023
Signed-off-by: Austin Littley <austin@swirldslabs.com>
iwsimon pushed a commit that referenced this pull request Dec 15, 2023
Signed-off-by: Austin Littley <austin@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a TEST ONLY setting to force ignore PCES signatures
3 participants