-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add test setting to force ignore PCES signatures #10538
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
litt3
commented
Dec 15, 2023
- closes Add a TEST ONLY setting to force ignore PCES signatures #10537
Signed-off-by: Austin Littley <austin@swirldslabs.com>
litt3
requested review from
cody-littley,
edward-swirldslabs and
lpetrovic05
December 15, 2023 15:09
cody-littley
approved these changes
Dec 15, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #10538 +/- ##
=============================================
- Coverage 63.01% 62.99% -0.02%
+ Complexity 30824 30819 -5
=============================================
Files 3363 3363
Lines 135414 135416 +2
Branches 14092 14090 -2
=============================================
- Hits 85325 85309 -16
- Misses 46730 46752 +22
+ Partials 3359 3355 -4 ☔ View full report in Codecov by Sentry. |
edward-swirldslabs
approved these changes
Dec 15, 2023
litt3
added a commit
that referenced
this pull request
Dec 15, 2023
Signed-off-by: Austin Littley <austin@swirldslabs.com>
litt3
added a commit
that referenced
this pull request
Dec 15, 2023
Signed-off-by: Austin Littley <austin@swirldslabs.com>
iwsimon
pushed a commit
that referenced
this pull request
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.