Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable passing ContractCallSuite specs #10528

Merged
merged 3 commits into from
Dec 18, 2023

Conversation

tinker-michaelj
Copy link
Collaborator

@tinker-michaelj tinker-michaelj commented Dec 14, 2023

Description:

  • Closes ContractCallSuite.hollowCreationFailsCleanly() #10520 by enabling two passing specs
  • Stabilizes CI by:
    1. Clearing RECORD_STREAM_ACCESS's map of listeners so it will reconstruct watchers as needed.
    2. Setting the end-of-staking period memo on the record of the synthetic NodeStakeUpdateTransaction so these transactions will be correctly skipped in getTxnRecord() child record assertions.

Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
@tinker-michaelj tinker-michaelj requested a review from a team December 14, 2023 22:36
@tinker-michaelj tinker-michaelj requested a review from a team as a code owner December 14, 2023 22:36
mhess-swl
mhess-swl previously approved these changes Dec 14, 2023
Copy link

github-actions bot commented Dec 14, 2023

Node: HAPI Test (Token) Results

189 tests   189 ✔️  18m 29s ⏱️
  13 suites      0 💤
  13 files        0

Results for commit 3792ee0.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 14, 2023

Node: HAPI Test (Crypto) Results

211 tests   204 ✔️  18m 22s ⏱️
  22 suites      7 💤
  22 files        0

Results for commit 3792ee0.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 14, 2023

Node: Unit Test Results

    2 293 files  +  2      2 293 suites  +2   49m 59s ⏱️ - 4m 58s
118 445 tests +18  118 411 ✔️ +18  34 💤 ±0  0 ±0 
126 862 runs  +14  126 828 ✔️ +14  34 💤 ±0  0 ±0 

Results for commit 3792ee0. ± Comparison against base commit 741094c.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 14, 2023

Node: HAPI Test (Time Consuming) Results

21 tests     9 ✔️  24m 45s ⏱️
  2 suites  12 💤
  2 files      0

Results for commit 3792ee0.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 14, 2023

Node: E2E Test Results

    1 files      1 suites   24m 20s ⏱️
311 tests 311 ✔️ 0 💤 0
333 runs  333 ✔️ 0 💤 0

Results for commit 3792ee0.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (develop@741094c). Click here to learn what that means.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop   #10528   +/-   ##
==========================================
  Coverage           ?   62.98%           
  Complexity         ?    30815           
==========================================
  Files              ?     3363           
  Lines              ?   135416           
  Branches           ?    14090           
==========================================
  Hits               ?    85291           
  Misses             ?    46766           
  Partials           ?     3359           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 14, 2023

Node: Integration Test Results

278 tests  ±0   278 ✔️ +1   26m 49s ⏱️ -10s
    5 suites ±0       0 💤 ±0 
    5 files   ±0       0  - 1 

Results for commit 3792ee0. ± Comparison against base commit 741094c.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 14, 2023

Node: HAPI Test (Smart Contract) Results

398 tests   368 ✔️  47m 14s ⏱️
  55 suites    30 💤
  55 files        0

Results for commit 3792ee0.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 15, 2023

Node: HAPI Test (Misc) Results

420 tests   329 ✔️  30m 6s ⏱️
  74 suites    91 💤
  74 files        0

Results for commit 3792ee0.

♻️ This comment has been updated with latest results.

Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Copy link
Member

@Neeharika-Sompalli Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@tinker-michaelj tinker-michaelj merged commit fb1165e into develop Dec 18, 2023
35 checks passed
@tinker-michaelj tinker-michaelj deleted the 10520-enable-ccall-specs branch December 18, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ContractCallSuite.hollowCreationFailsCleanly()
3 participants