fix: Override properties for Issue2098Spec
#10511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
Issue2098SpecIssue2098Spec
Issue2098SpecIssue2098Spec
tinker-michaelj
approved these changes
Dec 14, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #10511 +/- ##
==========================================
Coverage ? 63.02%
Complexity ? 30810
==========================================
Files ? 3361
Lines ? 135367
Branches ? 14085
==========================================
Hits ? 85312
Misses ? 46699
Partials ? 3356 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR changes the tests by instead of erasing the property it sets them to 0-1. Which is essentially the same thing, as far as the testing is concern.
Related issue(s):
Fixes #8769
Notes for reviewer:
Checklist