Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: windows runner failure when verifying the artifact determinism #10461

Merged
merged 4 commits into from
Dec 13, 2023

Conversation

nathanklick
Copy link
Member

Description

This pull request changes the following:

  • Fixes an issue with the windows runners generating sha256sum output containing a leading asterisk * mark.
  • Adds the determinism test as a pull request check.

Related Issues

Signed-off-by: Nathan Klick <nathan@swirldslabs.com>
@nathanklick nathanklick self-assigned this Dec 13, 2023
@nathanklick nathanklick requested review from a team as code owners December 13, 2023 00:32
Signed-off-by: Nathan Klick <nathan@swirldslabs.com>
Copy link

github-actions bot commented Dec 13, 2023

Node: HAPI Test (Token) Results

189 tests  ±0   189 ✔️ ±0   16m 50s ⏱️ + 1m 0s
  13 suites ±0       0 💤 ±0 
  13 files   ±0       0 ±0 

Results for commit 7f312f3. ± Comparison against base commit aff5fce.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 13, 2023

Node: HAPI Test (Crypto) Results

211 tests  ±0   201 ✔️ ±0   16m 36s ⏱️ +50s
  22 suites ±0     10 💤 ±0 
  22 files   ±0       0 ±0 

Results for commit 7f312f3. ± Comparison against base commit aff5fce.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 13, 2023

Node: Unit Test Results

    2 291 files  ±0      2 291 suites  ±0   53m 53s ⏱️ + 3m 42s
118 429 tests +3  118 395 ✔️ +3  34 💤 ±0  0 ±0 
126 850 runs  +3  126 816 ✔️ +3  34 💤 ±0  0 ±0 

Results for commit 7f312f3. ± Comparison against base commit aff5fce.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (aff5fce) 63.01% compared to head (7f312f3) 63.01%.
Report is 2 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop   #10461   +/-   ##
==========================================
  Coverage      63.01%   63.01%           
- Complexity     30803    30804    +1     
==========================================
  Files           3360     3360           
  Lines         135297   135346   +49     
  Branches       14073    14088   +15     
==========================================
+ Hits           85258    85290   +32     
- Misses         46690    46695    +5     
- Partials        3349     3361   +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 13, 2023

Node: E2E Test Results

    1 files  ±    0      1 suites  ±0   22m 9s ⏱️ + 22m 9s
311 tests +310  311 ✔️ +311  0 💤 ±0  0  - 1 
333 runs  +332  333 ✔️ +333  0 💤 ±0  0  - 1 

Results for commit 7f312f3. ± Comparison against base commit aff5fce.

This pull request removes 1 and adds 311 tests. Note that renamed tests count towards both.
EndToEndTests ‑ initializationError
EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateADDRESS_BOOK
EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateNODE_DETAILS
EndToEndTests ‑ AccountsGetPayerRecordsIfSoConfigured
EndToEndTests ‑ Acct57CanMakeSmallChanges
EndToEndTests ‑ Acct57CantMakeLargeChanges
EndToEndTests ‑ AddingSignaturesToExecutedTxFails
EndToEndTests ‑ AddingSignaturesToExecutedTxFailsWithLongTermEnabled
EndToEndTests ‑ AddingSignaturesToNonExistingTxFails
EndToEndTests ‑ AddingSignaturesToNonExistingTxFailsWithLongTermEnabled
EndToEndTests ‑ AddressAliasIdFuzzing
…

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 13, 2023

Node: HAPI Test (Misc) Results

420 tests  ±0   319 ✔️  - 1   23m 17s ⏱️ -29s
  74 suites ±0   101 💤 +1 
  74 files   ±0       0 ±0 

Results for commit 7f312f3. ± Comparison against base commit aff5fce.

This pull request skips 1 test.
com.hedera.services.bdd.suites.file.FileUpdateSuite ‑ optimisticSpecialFileUpdate

♻️ This comment has been updated with latest results.

JeffreyDallas
JeffreyDallas previously approved these changes Dec 13, 2023
Copy link

github-actions bot commented Dec 13, 2023

Node: HAPI Test (Time Consuming) Results

21 tests  ±0     9 ✔️ ±0   25m 36s ⏱️ +31s
  2 suites ±0   12 💤 ±0 
  2 files   ±0     0 ±0 

Results for commit 7f312f3. ± Comparison against base commit aff5fce.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 13, 2023

Node: Integration Test Results

279 tests  ±0   279 ✔️ ±0   28m 30s ⏱️ +16s
    5 suites ±0       0 💤 ±0 
    5 files   ±0       0 ±0 

Results for commit 7f312f3. ± Comparison against base commit aff5fce.

♻️ This comment has been updated with latest results.

leninmehedy
leninmehedy previously approved these changes Dec 13, 2023
Copy link

github-actions bot commented Dec 13, 2023

Node: HAPI Test (Smart Contract) Results

398 tests  +1   357 ✔️ +1   42m 38s ⏱️ - 1m 47s
  55 suites ±0     41 💤 ±0 
  55 files   ±0       0 ±0 

Results for commit 7f312f3. ± Comparison against base commit aff5fce.

♻️ This comment has been updated with latest results.

Signed-off-by: Nathan Klick <nathan@swirldslabs.com>
Signed-off-by: Nathan Klick <nathan@swirldslabs.com>
@nathanklick nathanklick merged commit f5e85f4 into develop Dec 13, 2023
35 checks passed
@nathanklick nathanklick deleted the 10454-Artifact-Check-Windows branch December 13, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: Fix Artifact check to correctly compare manifests on Windows machines
4 participants