Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make event descriptor building and accessing thread safe #10445

Merged
merged 2 commits into from
Dec 12, 2023

Conversation

litt3
Copy link
Contributor

@litt3 litt3 commented Dec 12, 2023

Signed-off-by: Austin Littley <austin@swirldslabs.com>
@litt3 litt3 added this to the v0.46 milestone Dec 12, 2023
@litt3 litt3 self-assigned this Dec 12, 2023
Copy link

github-actions bot commented Dec 12, 2023

Node: HAPI Test (Token) Results

189 tests  ±0   189 ✔️ ±0   17m 28s ⏱️ -10s
  13 suites ±0       0 💤 ±0 
  13 files   ±0       0 ±0 

Results for commit 642dc76. ± Comparison against base commit 6f00b68.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 12, 2023

Node: HAPI Test (Crypto) Results

211 tests  ±0   201 ✔️ ±0   16m 44s ⏱️ +6s
  22 suites ±0     10 💤 ±0 
  22 files   ±0       0 ±0 

Results for commit 642dc76. ± Comparison against base commit 6f00b68.

♻️ This comment has been updated with latest results.

@litt3 litt3 marked this pull request as ready for review December 12, 2023 18:08
@litt3 litt3 requested a review from a team as a code owner December 12, 2023 18:08
Copy link

github-actions bot commented Dec 12, 2023

Node: Unit Test Results

    2 291 files  ±0      2 291 suites  ±0   43m 52s ⏱️ - 2m 39s
118 426 tests ±0  118 392 ✔️ ±0  34 💤 ±0  0 ±0 
126 847 runs  ±0  126 813 ✔️ ±0  34 💤 ±0  0 ±0 

Results for commit 642dc76. ± Comparison against base commit 6f00b68.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 12, 2023

Node: HAPI Test (Misc) Results

420 tests  ±0   320 ✔️ ±0   24m 44s ⏱️ +41s
  74 suites ±0   100 💤 ±0 
  74 files   ±0       0 ±0 

Results for commit 642dc76. ± Comparison against base commit 6f00b68.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (6f00b68) 63.02% compared to head (c1f3041) 63.02%.
Report is 3 commits behind head on develop.

❗ Current head c1f3041 differs from pull request most recent head 642dc76. Consider uploading reports for the commit 642dc76 to get more accurate results

Files Patch % Lines
...form/event/creation/tipset/TipsetEventCreator.java 0.00% 3 Missing ⚠️
...n/java/com/swirlds/platform/event/GossipEvent.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop   #10445   +/-   ##
==========================================
  Coverage      63.02%   63.02%           
+ Complexity     30803    30799    -4     
==========================================
  Files           3359     3359           
  Lines         135279   135277    -2     
  Branches       14074    14073    -1     
==========================================
  Hits           85256    85256           
+ Misses         46683    46672   -11     
- Partials        3340     3349    +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 12, 2023

Node: HAPI Test (Time Consuming) Results

21 tests  ±0     9 ✔️ ±0   25m 11s ⏱️ -1s
  2 suites ±0   12 💤 ±0 
  2 files   ±0     0 ±0 

Results for commit 642dc76. ± Comparison against base commit 6f00b68.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 12, 2023

Node: E2E Test Results

    1 files  ±    0      1 suites  ±0   23m 19s ⏱️ + 23m 19s
311 tests +310  311 ✔️ +311  0 💤 ±0  0  - 1 
333 runs  +332  333 ✔️ +333  0 💤 ±0  0  - 1 

Results for commit 642dc76. ± Comparison against base commit 6f00b68.

This pull request removes 1 and adds 311 tests. Note that renamed tests count towards both.
EndToEndTests ‑ initializationError
EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateADDRESS_BOOK
EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateNODE_DETAILS
EndToEndTests ‑ AccountsGetPayerRecordsIfSoConfigured
EndToEndTests ‑ Acct57CanMakeSmallChanges
EndToEndTests ‑ Acct57CantMakeLargeChanges
EndToEndTests ‑ AddingSignaturesToExecutedTxFails
EndToEndTests ‑ AddingSignaturesToExecutedTxFailsWithLongTermEnabled
EndToEndTests ‑ AddingSignaturesToNonExistingTxFails
EndToEndTests ‑ AddingSignaturesToNonExistingTxFailsWithLongTermEnabled
EndToEndTests ‑ AddressAliasIdFuzzing
…

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 12, 2023

Node: Integration Test Results

279 tests  ±0   279 ✔️ ±0   27m 56s ⏱️ -29s
    5 suites ±0       0 💤 ±0 
    5 files   ±0       0 ±0 

Results for commit 642dc76. ± Comparison against base commit 6f00b68.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 12, 2023

Node: HAPI Test (Smart Contract) Results

397 tests  ±0   356 ✔️ ±0   44m 3s ⏱️ - 1m 19s
  55 suites ±0     41 💤 ±0 
  55 files   ±0       0 ±0 

Results for commit 642dc76. ± Comparison against base commit 6f00b68.

♻️ This comment has been updated with latest results.

Signed-off-by: Austin Littley <austin@swirldslabs.com>
@litt3 litt3 requested a review from a team as a code owner December 12, 2023 19:34
@litt3 litt3 requested a review from mxtartaglia-sl December 12, 2023 19:34
@litt3 litt3 merged commit aff5fce into develop Dec 12, 2023
27 checks passed
@litt3 litt3 deleted the 10444-threadsafe-descriptor branch December 12, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EventDescriptor access is thread unsafe
3 participants