-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Issue305Spec
test
#10437
fix: Issue305Spec
test
#10437
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #10437 +/- ##
=============================================
- Coverage 62.79% 62.79% -0.01%
+ Complexity 30884 30881 -3
=============================================
Files 3375 3375
Lines 136336 136336
Branches 14206 14206
=============================================
- Hits 85615 85607 -8
- Misses 47326 47331 +5
- Partials 3395 3398 +3 ☔ View full report in Codecov by Sentry. |
Node: E2E Test Results 1 files ± 0 1 suites ±0 23m 36s ⏱️ + 23m 36s Results for commit 573d4fe. ± Comparison against base commit 0f965a4. This pull request removes 1 and adds 311 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
The merge-base changed after approval.
a48901b
to
bd04743
Compare
Signed-off-by: dikel <dikelito@tutamail.com>
bd04743
to
19cfbc0
Compare
Signed-off-by: dikel <dikelito@tutamail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will be fixed by #10640 (need to ensure gas throttling is ON).
Description:
Adds
@HapiTest
annotation tocongestionMultipliersRefreshOnPropertyUpdate
Related issue(s):
Fixes #8774
Checklist