chore: create a state signer component #10411

lpetrovic05 · 2023-12-11T12:35:51Z

closes #10319

...sdk/swirlds-config-impl/src/main/java/com/swirlds/config/impl/internal/ConverterService.java

github-actions · 2023-12-11T13:12:36Z

Node: HAPI Test (Crypto) Results

211 tests 201 ✔️ 18m 41s ⏱️
  22 suites   10 💤
  22 files     0 ❌

Results for commit f8904cf.

♻️ This comment has been updated with latest results.

github-actions · 2023-12-11T13:14:13Z

Node: Unit Test Results

    2 291 files ±0     2 291 suites ±0 50m 3s ⏱️ + 3m 32s
118 426 tests ±0 118 392 ✔️ ±0 34 💤 ±0 0 ❌ ±0
126 847 runs ±0 126 813 ✔️ ±0 34 💤 ±0 0 ❌ ±0

Results for commit f8904cf. ± Comparison against base commit 6f00b68.

♻️ This comment has been updated with latest results.

github-actions · 2023-12-11T13:14:29Z

Node: HAPI Test (Token) Results

189 tests 189 ✔️ 18m 1s ⏱️
  13 suites     0 💤
  13 files     0 ❌

Results for commit f8904cf.

♻️ This comment has been updated with latest results.

github-actions · 2023-12-11T13:17:22Z

Node: E2E Test Results

    1 files     1 suites 26m 2s ⏱️
311 tests 311 ✔️ 0 💤 0 ❌
333 runs 333 ✔️ 0 💤 0 ❌

Results for commit f8904cf.

♻️ This comment has been updated with latest results.

github-actions · 2023-12-11T13:18:38Z

Node: HAPI Test (Misc) Results

420 tests 320 ✔️ 24m 30s ⏱️
  74 suites 100 💤
  74 files     0 ❌

Results for commit f8904cf.

♻️ This comment has been updated with latest results.

github-actions · 2023-12-11T13:18:48Z

Node: HAPI Test (Time Consuming) Results

21 tests   9 ✔️ 25m 17s ⏱️
  2 suites 12 💤
  2 files   0 ❌

Results for commit f8904cf.

♻️ This comment has been updated with latest results.

github-actions · 2023-12-11T13:22:49Z

Node: Integration Test Results

279 tests ±0 279 ✔️ ±0 28m 27s ⏱️ +2s
    5 suites ±0     0 💤 ±0
    5 files ±0     0 ❌ ±0

Results for commit f8904cf. ± Comparison against base commit 6f00b68.

♻️ This comment has been updated with latest results.

github-actions · 2023-12-11T13:45:26Z

Node: HAPI Test (Smart Contract) Results

397 tests 356 ✔️ 43m 36s ⏱️
  55 suites   41 💤
  55 files     0 ❌

Results for commit f8904cf.

♻️ This comment has been updated with latest results.

...sdk/swirlds-config-impl/src/main/java/com/swirlds/config/impl/internal/ConverterService.java

codecov · 2023-12-12T11:44:28Z

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (develop@6f00b68). Click here to learn what that means.

Additional details and impacted files

@@            Coverage Diff             @@
##             develop   #10411   +/-   ##
==========================================
  Coverage           ?   63.02%           
  Complexity         ?    30802           
==========================================
  Files              ?     3360           
  Lines              ?   135283           
  Branches           ?    14075           
==========================================
  Hits               ?    85258           
  Misses             ?    46680           
  Partials           ?     3345

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>

...ore/src/main/java/com/swirlds/platform/components/state/DefaultStateManagementComponent.java

.../swirlds-platform-core/src/main/java/com/swirlds/platform/eventhandling/TransactionPool.java

...-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/wiring/PlatformSchedulers.java

mxtartaglia-sl · 2023-12-13T20:23:02Z

...sdk/swirlds-config-impl/src/main/java/com/swirlds/config/impl/internal/ConverterService.java

+        if (converter == null && targetClass.isEnum()) {
+            // FUTURE WORK: once logging is added to this module, log a warning here
+            // ("No converter defined for type '" + targetClass + "'. Converting using backup enum converter.");
+            try {
+                return (T) Enum.valueOf((Class<Enum>) targetClass, value);
+            } catch (final IllegalArgumentException e) {
+                throw new IllegalArgumentException(
+                        "Can not convert value '%s' of Enum '%s' by default. Please add a custom config converter."
+                                .formatted(value, targetClass),
+                        e);
+            }
+        }


This is cool, the only problem that I see is that after this change, the method
getConverterForType(@NonNull final Class<T> valueType)
would work inconsistently compared with #convert.

Regardless I don't think that the change required to address my comment is in the scope of the current task. What do you think @hendrikebbers should we create a follow-up task to make those two behaviors consistent on our side?

lpetrovic05 added this to the v0.46 milestone Dec 11, 2023

lpetrovic05 self-assigned this Dec 11, 2023

lpetrovic05 commented Dec 11, 2023

View reviewed changes

...sdk/swirlds-config-impl/src/main/java/com/swirlds/config/impl/internal/ConverterService.java Outdated Show resolved Hide resolved

lpetrovic05 marked this pull request as ready for review December 11, 2023 12:46

lpetrovic05 requested review from a team as code owners December 11, 2023 12:46

lpetrovic05 requested review from poulok, mxtartaglia-sl, anthony-swirldslabs, cody-littley and litt3 December 11, 2023 12:46

cody-littley previously approved these changes Dec 11, 2023

View reviewed changes

lpetrovic05 dismissed cody-littley’s stale review via be09507 December 12, 2023 11:10

lpetrovic05 requested review from cody-littley, timo0 and hendrikebbers December 12, 2023 11:10

hendrikebbers reviewed Dec 12, 2023

View reviewed changes

...sdk/swirlds-config-impl/src/main/java/com/swirlds/config/impl/internal/ConverterService.java Outdated Show resolved Hide resolved

lpetrovic05 requested a review from hendrikebbers December 12, 2023 11:58

nathanklick force-pushed the develop branch from d971a0f to 6353aeb Compare December 12, 2023 14:05

lpetrovic05 requested a review from a team as a code owner December 12, 2023 14:05

lpetrovic05 requested review from OlegMazurov, iwsimon and acuarica December 12, 2023 14:05

lpetrovic05 added 17 commits December 12, 2023 15:53

10319 added all the wiring stuff

92c7a16

Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>

10319 wired up everything

bd045ac

Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>

10319 late disk save

91c9ae3

Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>

fix the converting

22e9828

Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>

comment

88c14bc

Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>

javadocs

f6cb831

Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>

more removal

648ed92

Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>

spot

ddad748

Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>

javadoc

150a254

Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>

backup enum converter

452549b

Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>

added FW

46c3408

Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>

compile

1078775

Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>

spot

1eaf0a8

Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>

better exception

9e1b32c

Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>

spot

627afc7

Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>

compile

0ad5a02

Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>

spot

f8904cf

Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>

lpetrovic05 force-pushed the 10319-D-create-a-state-signer-component branch from e8d6481 to f8904cf Compare December 12, 2023 14:57

imalygin approved these changes Dec 12, 2023

View reviewed changes

jeromy-cannon approved these changes Dec 12, 2023

View reviewed changes

litt3 approved these changes Dec 12, 2023

View reviewed changes

hendrikebbers approved these changes Dec 13, 2023

View reviewed changes

cody-littley approved these changes Dec 13, 2023

View reviewed changes

lpetrovic05 merged commit c7dd6e7 into develop Dec 13, 2023
24 checks passed

lpetrovic05 deleted the 10319-D-create-a-state-signer-component branch December 13, 2023 16:38

mxtartaglia-sl reviewed Dec 13, 2023

View reviewed changes

mxtartaglia-sl mentioned this pull request Dec 15, 2023

Create enum converter for simple enum types #10535

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: create a state signer component #10411

chore: create a state signer component #10411

lpetrovic05 commented Dec 11, 2023

github-actions bot commented Dec 11, 2023 •

edited

Loading

github-actions bot commented Dec 11, 2023 •

edited

Loading

github-actions bot commented Dec 11, 2023 •

edited

Loading

github-actions bot commented Dec 11, 2023 •

edited

Loading

github-actions bot commented Dec 11, 2023 •

edited

Loading

github-actions bot commented Dec 11, 2023 •

edited

Loading

github-actions bot commented Dec 11, 2023 •

edited

Loading

github-actions bot commented Dec 11, 2023 •

edited

Loading

codecov bot commented Dec 12, 2023 •

edited

Loading

mxtartaglia-sl Dec 13, 2023 •

edited

Loading

chore: create a state signer component #10411

chore: create a state signer component #10411

Conversation

lpetrovic05 commented Dec 11, 2023

github-actions bot commented Dec 11, 2023 • edited Loading

Node: HAPI Test (Crypto) Results

github-actions bot commented Dec 11, 2023 • edited Loading

Node: Unit Test Results

github-actions bot commented Dec 11, 2023 • edited Loading

Node: HAPI Test (Token) Results

github-actions bot commented Dec 11, 2023 • edited Loading

Node: E2E Test Results

github-actions bot commented Dec 11, 2023 • edited Loading

Node: HAPI Test (Misc) Results

github-actions bot commented Dec 11, 2023 • edited Loading

Node: HAPI Test (Time Consuming) Results

github-actions bot commented Dec 11, 2023 • edited Loading

Node: Integration Test Results

github-actions bot commented Dec 11, 2023 • edited Loading

Node: HAPI Test (Smart Contract) Results

codecov bot commented Dec 12, 2023 • edited Loading

Codecov Report

mxtartaglia-sl Dec 13, 2023 • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Dec 11, 2023 •

edited

Loading

github-actions bot commented Dec 11, 2023 •

edited

Loading

github-actions bot commented Dec 11, 2023 •

edited

Loading

github-actions bot commented Dec 11, 2023 •

edited

Loading

github-actions bot commented Dec 11, 2023 •

edited

Loading

github-actions bot commented Dec 11, 2023 •

edited

Loading

github-actions bot commented Dec 11, 2023 •

edited

Loading

github-actions bot commented Dec 11, 2023 •

edited

Loading

codecov bot commented Dec 12, 2023 •

edited

Loading

mxtartaglia-sl Dec 13, 2023 •

edited

Loading