chore!: remove swirlds-commons dependency from swirlds-config-impl
#10386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
Node: E2E Test Results 1 files ± 0 1 suites ±0 21m 49s ⏱️ + 21m 49s Results for commit eefdf33. ± Comparison against base commit d0e5885. This pull request removes 1 and adds 311 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
cody-littley
previously approved these changes
Dec 8, 2023
# Conflicts: # platform-sdk/swirlds-common/src/test/java/com/swirlds/common/metrics/platform/prometheus/PrometheusEndpointTest.java # platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/event/preconsensus/PreconsensusEventFileManager.java # platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/metrics/SyncMetrics.java
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #10386 +/- ##
=============================================
- Coverage 62.97% 62.97% -0.01%
- Complexity 30794 30795 +1
=============================================
Files 3356 3354 -2
Lines 135216 135208 -8
Branches 14076 14076
=============================================
- Hits 85152 85144 -8
+ Misses 46728 46727 -1
- Partials 3336 3337 +1 ☔ View full report in Codecov by Sentry. |
lpetrovic05
approved these changes
Dec 11, 2023
jeromy-cannon
approved these changes
Dec 11, 2023
imalygin
approved these changes
Dec 11, 2023
cody-littley
approved these changes
Dec 11, 2023
Neeharika-Sompalli
approved these changes
Dec 11, 2023
david-bakin-sl
approved these changes
Dec 11, 2023
There was a problem hiding this comment.
Looking only at hedera-smart-contract-service LGTM. (There was nothing contract related in hedera-mono-service.
Suggest changing PR title and/or PR comment to make it clear, here in this PR, that the common you're talking about is swirlds-common and not, say, Apache common. I mean, it's clear from the code, but if you're looking at, say, release notes, it might be nicer to have it there.
swirlds-common dependency from swirlds-config-impl
swirlds-common dependency from swirlds-config-implswirlds-common dependency from swirlds-config-impl
swirlds-common dependency from swirlds-config-implswirlds-commons dependency from swirlds-config-impl
mxtartaglia-sl
approved these changes
Dec 11, 2023
nathanklick
pushed a commit
that referenced
this pull request
Dec 12, 2023
…#10386) Signed-off-by: Timo Brandstätter <timo@swirldslabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9002