-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement lazyCreationCostInGas method #10337
Conversation
Signed-off-by: lukelee-sl <luke.lee@swirldslabs.com>
Signed-off-by: lukelee-sl <luke.lee@swirldslabs.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #10337 +/- ##
=============================================
- Coverage 63.51% 63.51% -0.01%
+ Complexity 30992 30988 -4
=============================================
Files 3340 3340
Lines 134557 134576 +19
Branches 13994 13994
=============================================
+ Hits 85470 85481 +11
- Misses 45727 45731 +4
- Partials 3360 3364 +4 ☔ View full report in Codecov by Sentry. |
Node: E2E Test Results 1 files ± 0 1 suites ±0 23m 32s ⏱️ + 23m 32s Results for commit 06e5ab1. ± Comparison against base commit bac40bd. This pull request removes 1 and adds 311 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - with one minor comment.
...va/com/hedera/node/app/service/contract/impl/test/exec/scope/HandleHederaOperationsTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: lukelee-sl <luke.lee@swirldslabs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks right to me, tyvm @lukelee-sl !
Description:
Implement the
lazyCreationCostInGas
method in theHandleHederaOperations
class.Related issue(s):
Fixes #10336
Notes for reviewer:
This was part of a larger pr but is pulled out to potentially unblock some HAPI tests that depend on this functionality.
Checklist