-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: canUseAliasesInPrecompilesAndContractKeys checks EVM_ADDRESS is 20 bytes #10327
Conversation
Signed-off-by: Alexander Gadzhalov <alexander.gadzhalov@limechain.tech>
Node: HAPI Test (Token) Results189 tests - 1 189 ✔️ +1 19m 19s ⏱️ + 1m 5s Results for commit b976fc1. ± Comparison against base commit 719f074. This pull request removes 1 test.
♻️ This comment has been updated with latest results. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #10327 +/- ##
=============================================
- Coverage 63.55% 63.52% -0.04%
- Complexity 30999 31009 +10
=============================================
Files 3340 3342 +2
Lines 134485 134693 +208
Branches 13981 14005 +24
=============================================
+ Hits 85477 85563 +86
- Misses 45644 45771 +127
+ Partials 3364 3359 -5 ☔ View full report in Codecov by Sentry. |
Node: E2E Test Results 1 files ± 0 1 suites ±0 23m 31s ⏱️ + 23m 31s Results for commit b976fc1. ± Comparison against base commit 719f074. This pull request removes 1 and adds 311 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah we need to also handle the hasDelegatableContractId()
case---see here. I think this is why unit tests are failing.
Signed-off-by: Alexander Gadzhalov <alexander.gadzhalov@limechain.tech>
Signed-off-by: Alexander Gadzhalov <alexander.gadzhalov@limechain.tech>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description:
canUseAliasesInPrecompilesAndContractKeys additional validation to check if EVM_ADDRESS is 20 bytes
Related issue(s):
Fixes #10251