Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: canUseAliasesInPrecompilesAndContractKeys checks EVM_ADDRESS is 20 bytes #10327

Merged
merged 3 commits into from
Dec 7, 2023

Conversation

agadzhalov
Copy link
Contributor

@agadzhalov agadzhalov commented Dec 6, 2023

Description:
canUseAliasesInPrecompilesAndContractKeys additional validation to check if EVM_ADDRESS is 20 bytes

Related issue(s):

Fixes #10251

Signed-off-by: Alexander Gadzhalov <alexander.gadzhalov@limechain.tech>
Copy link

github-actions bot commented Dec 6, 2023

Node: Unit Test Results

    2 294 files  +1      2 294 suites  +1   50m 45s ⏱️ + 7m 27s
118 433 tests +4  118 399 ✔️ +4  34 💤 ±0  0 ±0 
126 855 runs  +4  126 821 ✔️ +4  34 💤 ±0  0 ±0 

Results for commit b976fc1. ± Comparison against base commit 719f074.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 6, 2023

Node: HAPI Test (Token) Results

189 tests   - 1   189 ✔️ +1   19m 19s ⏱️ + 1m 5s
  13 suites ±0       0 💤  - 2 
  13 files   ±0       0 ±0 

Results for commit b976fc1. ± Comparison against base commit 719f074.

This pull request removes 1 test.
com.hedera.services.bdd.suites.token.TokenAssociationSpecs ‑ dissociationFromExpiredTokensAsExpected

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 6, 2023

Node: HAPI Test (Crypto) Results

211 tests  ±0   201 ✔️ ±0   19m 35s ⏱️ + 2m 12s
  22 suites ±0     10 💤 ±0 
  22 files   ±0       0 ±0 

Results for commit b976fc1. ± Comparison against base commit 719f074.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (719f074) 63.55% compared to head (b976fc1) 63.52%.
Report is 16 commits behind head on develop.

Files Patch % Lines
...ain/java/com/hedera/node/app/spi/key/KeyUtils.java 33.33% 0 Missing and 4 partials ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop   #10327      +/-   ##
=============================================
- Coverage      63.55%   63.52%   -0.04%     
- Complexity     30999    31009      +10     
=============================================
  Files           3340     3342       +2     
  Lines         134485   134693     +208     
  Branches       13981    14005      +24     
=============================================
+ Hits           85477    85563      +86     
- Misses         45644    45771     +127     
+ Partials        3364     3359       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 6, 2023

Node: HAPI Test (Time Consuming) Results

21 tests  ±0     9 ✔️ ±0   26m 11s ⏱️ + 1m 9s
  2 suites ±0   12 💤 ±0 
  2 files   ±0     0 ±0 

Results for commit b976fc1. ± Comparison against base commit 719f074.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 6, 2023

Node: E2E Test Results

    1 files  ±    0      1 suites  ±0   23m 31s ⏱️ + 23m 31s
311 tests +310  311 ✔️ +311  0 💤 ±0  0  - 1 
333 runs  +332  333 ✔️ +333  0 💤 ±0  0  - 1 

Results for commit b976fc1. ± Comparison against base commit 719f074.

This pull request removes 1 and adds 311 tests. Note that renamed tests count towards both.
EndToEndTests ‑ initializationError
EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateADDRESS_BOOK
EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateNODE_DETAILS
EndToEndTests ‑ AccountsGetPayerRecordsIfSoConfigured
EndToEndTests ‑ Acct57CanMakeSmallChanges
EndToEndTests ‑ Acct57CantMakeLargeChanges
EndToEndTests ‑ AddingSignaturesToExecutedTxFails
EndToEndTests ‑ AddingSignaturesToExecutedTxFailsWithLongTermEnabled
EndToEndTests ‑ AddingSignaturesToNonExistingTxFails
EndToEndTests ‑ AddingSignaturesToNonExistingTxFailsWithLongTermEnabled
EndToEndTests ‑ AddressAliasIdFuzzing
…

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 6, 2023

Node: HAPI Test (Misc) Results

419 tests  ±0   316 ✔️ ±0   26m 12s ⏱️ + 2m 14s
  73 suites ±0   103 💤 ±0 
  73 files   ±0       0 ±0 

Results for commit b976fc1. ± Comparison against base commit 719f074.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 6, 2023

Node: Integration Test Results

279 tests  ±0   279 ✔️ ±0   28m 6s ⏱️ -20s
    5 suites ±0       0 💤 ±0 
    5 files   ±0       0 ±0 

Results for commit b976fc1. ± Comparison against base commit 719f074.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 6, 2023

Node: HAPI Test (Smart Contract) Results

396 tests  ±0   350 ✔️ +1   48m 2s ⏱️ + 4m 7s
  55 suites ±0     46 💤  - 1 
  55 files   ±0       0 ±0 

Results for commit b976fc1. ± Comparison against base commit 719f074.

♻️ This comment has been updated with latest results.

@mustafauzunn mustafauzunn added the Limechain Work planned for the LimeChain team label Dec 7, 2023
Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah we need to also handle the hasDelegatableContractId() case---see here. I think this is why unit tests are failing.

Signed-off-by: Alexander Gadzhalov <alexander.gadzhalov@limechain.tech>
Signed-off-by: Alexander Gadzhalov <alexander.gadzhalov@limechain.tech>
@tinker-michaelj tinker-michaelj marked this pull request as ready for review December 7, 2023 20:42
@tinker-michaelj tinker-michaelj requested review from a team and jasperpotts December 7, 2023 20:42
Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tinker-michaelj tinker-michaelj merged commit 6816094 into develop Dec 7, 2023
29 of 30 checks passed
@tinker-michaelj tinker-michaelj deleted the 10251-fix-can-use-aliases-create2 branch December 7, 2023 20:43
@agadzhalov agadzhalov changed the title fix: canUseAliasesInPrecompilesAndContractKeys suite test fix: canUseAliasesInPrecompilesAndContractKeys checks EVM_ADDRESS is 20 bytes Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Limechain Work planned for the LimeChain team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix canUseAliasesInPrecompilesAndContractKeys
3 participants