Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Hook midnight rate updates into handle workflow #10322

Merged
merged 4 commits into from
Dec 8, 2023

Conversation

netopyr
Copy link
Contributor

@netopyr netopyr commented Dec 6, 2023

This PR ensures the midnight rates are updated when a new staking period begins.

Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
@netopyr netopyr added this to the v0.46 milestone Dec 6, 2023
@netopyr netopyr self-assigned this Dec 6, 2023
@netopyr netopyr requested review from a team and jasperpotts December 6, 2023 12:44
Copy link

github-actions bot commented Dec 6, 2023

Node: Unit Test Results

    2 294 files  ±0      2 294 suites  ±0   48m 10s ⏱️ + 1m 32s
118 433 tests ±0  118 399 ✔️ ±0  34 💤 ±0  0 ±0 
126 855 runs  ±0  126 821 ✔️ ±0  34 💤 ±0  0 ±0 

Results for commit 7675db2. ± Comparison against base commit d2f59e4.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (d2f59e4) 63.52% compared to head (7675db2) 63.52%.

Files Patch % Lines
...de/app/workflows/handle/StakingPeriodTimeHook.java 80.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop   #10322   +/-   ##
==========================================
  Coverage      63.52%   63.52%           
- Complexity     31008    31011    +3     
==========================================
  Files           3342     3342           
  Lines         134699   134709   +10     
  Branches       14005    14005           
==========================================
+ Hits           85563    85574   +11     
- Misses         45775    45777    +2     
+ Partials        3361     3358    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 6, 2023

Node: HAPI Test (Crypto) Results

211 tests  ±0   201 ✔️ ±0   18m 3s ⏱️ + 1m 1s
  22 suites ±0     10 💤 ±0 
  22 files   ±0       0 ±0 

Results for commit 7675db2. ± Comparison against base commit d2f59e4.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 6, 2023

Node: HAPI Test (Token) Results

189 tests  ±0   189 ✔️ ±0   19m 12s ⏱️ +48s
  13 suites ±0       0 💤 ±0 
  13 files   ±0       0 ±0 

Results for commit 7675db2. ± Comparison against base commit d2f59e4.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 6, 2023

Node: E2E Test Results

    1 files  ±    0      1 suites  ±0   23m 40s ⏱️ + 23m 40s
311 tests +310  311 ✔️ +311  0 💤 ±0  0  - 1 
333 runs  +332  333 ✔️ +333  0 💤 ±0  0  - 1 

Results for commit 7675db2. ± Comparison against base commit d2f59e4.

This pull request removes 1 and adds 311 tests. Note that renamed tests count towards both.
EndToEndTests ‑ initializationError
EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateADDRESS_BOOK
EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateNODE_DETAILS
EndToEndTests ‑ AccountsGetPayerRecordsIfSoConfigured
EndToEndTests ‑ Acct57CanMakeSmallChanges
EndToEndTests ‑ Acct57CantMakeLargeChanges
EndToEndTests ‑ AddingSignaturesToExecutedTxFails
EndToEndTests ‑ AddingSignaturesToExecutedTxFailsWithLongTermEnabled
EndToEndTests ‑ AddingSignaturesToNonExistingTxFails
EndToEndTests ‑ AddingSignaturesToNonExistingTxFailsWithLongTermEnabled
EndToEndTests ‑ AddressAliasIdFuzzing
…

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 6, 2023

Node: HAPI Test (Misc) Results

419 tests  ±0   316 ✔️ ±0   25m 24s ⏱️ -21s
  73 suites ±0   103 💤 ±0 
  73 files   ±0       0 ±0 

Results for commit 7675db2. ± Comparison against base commit d2f59e4.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 6, 2023

Node: HAPI Test (Time Consuming) Results

21 tests  ±0     9 ✔️ ±0   26m 36s ⏱️ +45s
  2 suites ±0   12 💤 ±0 
  2 files   ±0     0 ±0 

Results for commit 7675db2. ± Comparison against base commit d2f59e4.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 6, 2023

Node: Integration Test Results

279 tests  ±0   279 ✔️ ±0   28m 32s ⏱️ +22s
    5 suites ±0       0 💤 ±0 
    5 files   ±0       0 ±0 

Results for commit 7675db2. ± Comparison against base commit d2f59e4.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 6, 2023

Node: HAPI Test (Smart Contract) Results

396 tests  ±0   350 ✔️ ±0   46m 27s ⏱️ - 1m 11s
  55 suites ±0     46 💤 ±0 
  55 files   ±0       0 ±0 

Results for commit 7675db2. ± Comparison against base commit d2f59e4.

♻️ This comment has been updated with latest results.

Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

@netopyr netopyr merged commit d331244 into develop Dec 8, 2023
27 checks passed
@netopyr netopyr deleted the 07386-midnight-rate-updates-hook branch December 8, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants