Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 10116 intake clearing #10306

Merged
merged 13 commits into from
Dec 8, 2023
Merged

fix: 10116 intake clearing #10306

merged 13 commits into from
Dec 8, 2023

Conversation

litt3
Copy link
Contributor

@litt3 litt3 commented Dec 5, 2023 •
edited
Loading

Austin Littley added 4 commits December 5, 2023 13:40
Add clear functionality to individual intake components
9506e45 
Signed-off-by: Austin Littley <austin@swirldslabs.com>
Implement PlatformCoordinator
a346053 
Signed-off-by: Austin Littley <austin@swirldslabs.com>
Merge branch 'develop' into 10116-intake-clearing
e7827b5
Use the platform coordinator to clear system
e6535fa 
Signed-off-by: Austin Littley <austin@swirldslabs.com>
@litt3 litt3 added this to the v0.46 milestone Dec 5, 2023
@litt3 litt3 self-assigned this Dec 5, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2023 •
edited
Loading

Node: HAPI Test (Smart Contract) Results

397 tests   356 ✔️  56m 30s ⏱️
  55 suites    41 💤
  55 files        0 ❌

Results for commit 803f6d5.

♻️ This comment has been updated with latest results.

Apply spotless
21d41b9 
Signed-off-by: Austin Littley <austin@swirldslabs.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2023 •
edited
Loading

Node: Unit Test Results

    2 293 files  ±0      2 293 suites  ±0   47m 29s ⏱️ +18s
118 428 tests  - 1  118 394 ✔️  - 1  34 💤 ±0  0 ❌ ±0 
126 849 runs   - 1  126 815 ✔️  - 1  34 💤 ±0  0 ❌ ±0 

Results for commit 803f6d5. ± Comparison against base commit ff66d3e.

♻️ This comment has been updated with latest results.

@codecov Codecov
Copy link

codecov bot commented Dec 5, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (develop@ff66d3e). Click here to learn what that means.

Additional details and impacted files 
@@            Coverage Diff             @@
##             develop   #10306   +/-   ##
==========================================
  Coverage           ?   62.96%           
  Complexity         ?    30790           
==========================================
  Files              ?     3356           
  Lines              ?   135213           
  Branches           ?    14075           
==========================================
  Hits               ?    85141           
  Misses             ?    46733           
  Partials           ?     3339

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2023 •
edited
Loading

Node: HAPI Test (Token) Results

189 tests   189 ✔️  20m 38s ⏱️
  13 suites      0 💤
  13 files        0 ❌

Results for commit 803f6d5.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2023 •
edited
Loading

Node: HAPI Test (Crypto) Results

211 tests   201 ✔️  19m 44s ⏱️
  22 suites    10 💤
  22 files        0 ❌

Results for commit 803f6d5.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2023 •
edited
Loading

Node: HAPI Test (Misc) Results

420 tests  ±0   318 ✔️ ±0   25m 16s ⏱️ - 1m 4s
  74 suites ±0   102 💤 ±0 
  74 files   ±0       0 ❌ ±0 

Results for commit 803f6d5. ± Comparison against base commit ff66d3e.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2023 •
edited
Loading

Node: HAPI Test (Time Consuming) Results

21 tests     9 ✔️  25m 0s ⏱️
  2 suites  12 💤
  2 files      0 ❌

Results for commit 803f6d5.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2023 •
edited
Loading

Node: E2E Test Results

    1 files      1 suites   23m 40s ⏱️
311 tests 311 ✔️ 0 💤 0 ❌
333 runs  333 ✔️ 0 💤 0 ❌

Results for commit 803f6d5.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2023 •
edited
Loading

Node: Integration Test Results

279 tests   279 ✔️  28m 19s ⏱️
    5 suites      0 💤
    5 files        0 ❌

Results for commit 803f6d5.

♻️ This comment has been updated with latest results.

Austin Littley added 5 commits December 6, 2023 10:23
Remove unnecessary param
7274315 
Signed-off-by: Austin Littley <austin@swirldslabs.com>
Reorganize clearing
79754ef 
Signed-off-by: Austin Littley <austin@swirldslabs.com>
Merge branch 'develop' into 10116-intake-clearing
b33d5e6
Pause LinkedEventIntake instead of orphan buffer
8aa4ea9 
Signed-off-by: Austin Littley <austin@swirldslabs.com>
Change log marker
76822a0 
Signed-off-by: Austin Littley <austin@swirldslabs.com>
@litt3 litt3 marked this pull request as ready for review December 7, 2023 20:05
@litt3 litt3 requested a review from a team as a code owner December 7, 2023 20:05
Respond to PR comment
77f58aa 
Signed-off-by: Austin Littley <austin@swirldslabs.com>
cody-littley
cody-littley previously approved these changes Dec 7, 2023
View reviewed changes
Clear discarded EventImpls
52d81d0 
Signed-off-by: Austin Littley <austin@swirldslabs.com>
@litt3 litt3 mentioned this pull request Dec 8, 2023
Merged
@litt3 litt3 requested a review from cody-littley December 8, 2023 17:26
cody-littley
cody-littley previously approved these changes Dec 8, 2023
View reviewed changes
Merge branch 'develop' into 10116-intake-clearing
803f6d5 
Signed-off-by: Austin Littley <austin@swirldslabs.com>
@litt3 litt3 dismissed stale reviews from edward-swirldslabs and cody-littley via 803f6d5 December 8, 2023 19:03
@litt3 litt3 merged commit 8479a88 into develop Dec 8, 2023
29 checks passed
@litt3 litt3 deleted the 10116-intake-clearing branch December 8, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edward-swirldslabs edward-swirldslabs edward-swirldslabs approved these changes

@cody-littley cody-littley cody-littley approved these changes

@lpetrovic05 lpetrovic05 Awaiting requested review from lpetrovic05

Assignees

@litt3 litt3

Labels
None yet
Projects
None yet
Milestone
v0.46
Development

Successfully merging this pull request may close these issues.

Missing non-expired self parent in FCM-MultiSBReconnect-3R-1k-20m
3 participants
@litt3 @cody-littley @edward-swirldslabs