fix: 10227 use dev config with modrun #10249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nguyen Pham Truong Giang <jamesnguyen@var-meta.com>
nathanklick
requested changes
Dec 4, 2023
…r run task and release tasks/pipelines) Signed-off-by: Nguyen Pham Truong Giang <jamesnguyen@var-meta.com>
nathanklick
reviewed
Dec 4, 2023
nathanklick
previously approved these changes
Dec 4, 2023
Co-authored-by: Nathan Klick <nathan@swirldslabs.com> Signed-off-by: jamesnguyentech <82211356+jamesnguyentech@users.noreply.github.com>
nathanklick
previously approved these changes
Dec 4, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #10249 +/- ##
=============================================
+ Coverage 63.11% 63.51% +0.40%
- Complexity 30722 30953 +231
=============================================
Files 3335 3337 +2
Lines 134140 134351 +211
Branches 13914 13965 +51
=============================================
+ Hits 84659 85339 +680
+ Misses 46137 45656 -481
- Partials 3344 3356 +12 ☔ View full report in Codecov by Sentry. |
|
@jamesnguyentech Would you please run |
Signed-off-by: Nguyen Pham Truong Giang <jamesnguyen@var-meta.com>
|
@nathanklick I ran it. Could you check it again? |
nathanklick
approved these changes
Dec 7, 2023
|
@jamesnguyentech Looks great, as soon as the remaining test run finishes I will merge unless there is an error. The unit test failure is a known issue which has already been fixed in the latest |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR update modrun for running with the dev config.
Related issue(s):
Fixes #10227