-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: don't link parents if relationship to child is invalid #10235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
litt3
commented
Dec 1, 2023
- closes Add logic to skip linking invalid parent child relationships #10222
Signed-off-by: Austin Littley <austin@swirldslabs.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #10235 +/- ##
==========================================
Coverage ? 63.52%
Complexity ? 30957
==========================================
Files ? 3337
Lines ? 134380
Branches ? 13964
==========================================
Hits ? 85371
Misses ? 45650
Partials ? 3359 ☔ View full report in Codecov by Sentry. |
edward-swirldslabs
approved these changes
Dec 4, 2023
...dk/swirlds-platform-core/src/main/java/com/swirlds/platform/event/linking/InOrderLinker.java
Show resolved
Hide resolved
cody-littley
approved these changes
Dec 4, 2023
lpetrovic05
reviewed
Dec 5, 2023
...dk/swirlds-platform-core/src/main/java/com/swirlds/platform/event/linking/InOrderLinker.java
Show resolved
Hide resolved
lpetrovic05
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.