Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: don't link parents if relationship to child is invalid #10235

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

litt3
Copy link
Contributor

@litt3 litt3 commented Dec 1, 2023

Signed-off-by: Austin Littley <austin@swirldslabs.com>
@litt3 litt3 added this to the v0.46 milestone Dec 1, 2023
@litt3 litt3 self-assigned this Dec 1, 2023
Copy link

github-actions bot commented Dec 1, 2023

Node: HAPI Test (Crypto) Results

211 tests   201 ✔️  21m 38s ⏱️
  22 suites    10 💤
  22 files        0

Results for commit ff87d64.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 1, 2023

Node: Unit Test Results

    2 290 files  ±0      2 290 suites  ±0   44m 21s ⏱️ + 3m 54s
118 413 tests +3  118 379 ✔️ +3  34 💤 ±0  0 ±0 
126 835 runs  +3  126 801 ✔️ +3  34 💤 ±0  0 ±0 

Results for commit ff87d64. ± Comparison against base commit 3b0ea4f.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 1, 2023

Node: HAPI Test (Token) Results

190 tests   188 ✔️  21m 16s ⏱️
  13 suites      2 💤
  13 files        0

Results for commit ff87d64.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (develop@3b0ea4f). Click here to learn what that means.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop   #10235   +/-   ##
==========================================
  Coverage           ?   63.52%           
  Complexity         ?    30957           
==========================================
  Files              ?     3337           
  Lines              ?   134380           
  Branches           ?    13964           
==========================================
  Hits               ?    85371           
  Misses             ?    45650           
  Partials           ?     3359           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 1, 2023

Node: E2E Test Results

    1 files      1 suites   25m 51s ⏱️
311 tests 311 ✔️ 0 💤 0
333 runs  333 ✔️ 0 💤 0

Results for commit ff87d64.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 1, 2023

Node: HAPI Test (Misc) Results

419 tests   313 ✔️  28m 47s ⏱️
  73 suites  106 💤
  73 files        0

Results for commit ff87d64.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 1, 2023

Node: HAPI Test (Time Consuming) Results

21 tests     9 ✔️  25m 59s ⏱️
  2 suites  12 💤
  2 files      0

Results for commit ff87d64.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 1, 2023

Node: Integration Test Results

279 tests  ±0   279 ✔️ +1   28m 7s ⏱️ -1s
    5 suites ±0       0 💤 ±0 
    5 files   ±0       0  - 1 

Results for commit ff87d64. ± Comparison against base commit 3b0ea4f.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 1, 2023

Node: HAPI Test (Smart Contract) Results

405 tests   325 ✔️  48m 52s ⏱️
  56 suites    80 💤
  56 files        0

Results for commit ff87d64.

♻️ This comment has been updated with latest results.

@litt3 litt3 marked this pull request as ready for review December 4, 2023 16:20
@litt3 litt3 requested a review from a team as a code owner December 4, 2023 16:20
@litt3 litt3 merged commit d15181b into develop Dec 5, 2023
26 of 27 checks passed
@litt3 litt3 deleted the 10222-picky-linking branch December 5, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add logic to skip linking invalid parent child relationships
4 participants