Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: wiring diagram improvements #10233

Merged
merged 17 commits into from
Dec 1, 2023
Merged

Conversation

cody-littley
Copy link
Contributor

@cody-littley cody-littley commented Dec 1, 2023

Closes #10231

Some example diagrams generated from commands in diagram-commands.txt:

Note that the "♡" symbol is an input substitution for the heartbeat wire. Nothing in develop uses a heartbeat yet, but the event creation manager does. This substitution will make a lot more sense once things start using heartbeats.

Cody Littley added 14 commits November 22, 2023 12:31
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley cody-littley self-assigned this Dec 1, 2023
Cody Littley added 3 commits December 1, 2023 13:22
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley cody-littley changed the title 10231 diagram improvements feat: wiring diagram improvements Dec 1, 2023
@cody-littley cody-littley marked this pull request as ready for review December 1, 2023 19:49
@cody-littley cody-littley requested review from a team as code owners December 1, 2023 19:49
Copy link

github-actions bot commented Dec 1, 2023

Node: Unit Test Results

    2 288 files  ±0      2 288 suites  ±0   47m 10s ⏱️ + 3m 28s
118 397 tests ±0  118 363 ✔️ ±0  34 💤 ±0  0 ±0 
126 769 runs  ±0  126 735 ✔️ ±0  34 💤 ±0  0 ±0 

Results for commit 5001117. ± Comparison against base commit ba16e00.

Copy link

github-actions bot commented Dec 1, 2023

Node: HAPI Test (Token) Results

190 tests   188 ✔️  18m 26s ⏱️
  13 suites      2 💤
  13 files        0

Results for commit 5001117.

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Attention: 178 lines in your changes are missing coverage. Please review.

Comparison is base (ed23092) 63.16% compared to head (5001117) 63.11%.
Report is 6 commits behind head on develop.

Files Patch % Lines
.../common/wiring/model/internal/WiringFlowchart.java 29.41% 92 Missing and 4 partials ⚠️
...rlds/common/wiring/model/internal/GroupVertex.java 0.00% 34 Missing ⚠️
.../java/com/swirlds/platform/cli/DiagramCommand.java 0.00% 20 Missing ⚠️
...s/common/wiring/model/internal/StandardVertex.java 67.24% 14 Missing and 5 partials ⚠️
...wirlds/common/wiring/model/internal/ModelEdge.java 74.07% 6 Missing and 1 partial ⚠️
...lds/common/wiring/model/ModelEdgeSubstitution.java 0.00% 1 Missing ⚠️
...mon/wiring/model/internal/StandardWiringModel.java 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop   #10233      +/-   ##
=============================================
- Coverage      63.16%   63.11%   -0.05%     
- Complexity     30706    30722      +16     
=============================================
  Files           3329     3335       +6     
  Lines         133975   134139     +164     
  Branches       13884    13914      +30     
=============================================
+ Hits           84623    84660      +37     
- Misses         46008    46134     +126     
- Partials        3344     3345       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 1, 2023

Node: HAPI Test (Crypto) Results

183 tests   - 28   119 ✔️  - 25   12m 2s ⏱️ - 1m 55s
  21 suites  -   1       9 💤  -   1 
  22 files   ±  0     55  -   2 
    1 errors

For more details on these parsing errors and failures, see this check.

Results for commit 5001117. ± Comparison against base commit ba16e00.

This pull request removes 28 tests.
com.hedera.services.bdd.suites.crypto.CryptoTransferSuite ‑ aliasKeysAreValidated
com.hedera.services.bdd.suites.crypto.CryptoTransferSuite ‑ allowanceTransfersWithComplexTransfersWork
com.hedera.services.bdd.suites.crypto.CryptoTransferSuite ‑ allowanceTransfersWorkAsExpected
com.hedera.services.bdd.suites.crypto.CryptoTransferSuite ‑ autoAssociationRequiresOpenSlots
com.hedera.services.bdd.suites.crypto.CryptoTransferSuite ‑ baseCryptoTransferFeeChargedAsExpected
com.hedera.services.bdd.suites.crypto.CryptoTransferSuite ‑ canUseAliasAndAccountCombinations
com.hedera.services.bdd.suites.crypto.CryptoTransferSuite ‑ canUseEip1014AliasesForXfers
com.hedera.services.bdd.suites.crypto.CryptoTransferSuite ‑ canUseMirrorAliasesForNonContractXfers
com.hedera.services.bdd.suites.crypto.CryptoTransferSuite ‑ cannotTransferFromImmutableAccounts
com.hedera.services.bdd.suites.crypto.CryptoTransferSuite ‑ checksExpectedDecimalsForFungibleTokenTransferList
…

Copy link

github-actions bot commented Dec 1, 2023

Node: HAPI Test (Time Consuming) Results

21 tests     9 ✔️  24m 44s ⏱️
  2 suites  12 💤
  2 files      0

Results for commit 5001117.

Copy link

github-actions bot commented Dec 1, 2023

Node: E2E Test Results

    1 files      1 suites   23m 27s ⏱️
311 tests 311 ✔️ 0 💤 0
333 runs  333 ✔️ 0 💤 0

Results for commit 5001117.

Copy link

github-actions bot commented Dec 1, 2023

Node: HAPI Test (Misc) Results

419 tests  ±0   313 ✔️ ±0   27m 42s ⏱️ + 3m 0s
  73 suites ±0   106 💤 ±0 
  73 files   ±0       0 ±0 

Results for commit 5001117. ± Comparison against base commit ba16e00.

Copy link

github-actions bot commented Dec 1, 2023

Node: Integration Test Results

279 tests  ±0   279 ✔️ ±0   28m 22s ⏱️ +13s
    5 suites ±0       0 💤 ±0 
    5 files   ±0       0 ±0 

Results for commit 5001117. ± Comparison against base commit ba16e00.

Copy link

github-actions bot commented Dec 1, 2023

Node: HAPI Test (Smart Contract) Results

405 tests   325 ✔️  46m 14s ⏱️
  56 suites    80 💤
  56 files        0

Results for commit 5001117.

@cody-littley cody-littley merged commit fe02862 into develop Dec 1, 2023
23 of 29 checks passed
@cody-littley cody-littley deleted the 10231-diagram-improvements branch December 1, 2023 21:48
mhess-swl pushed a commit that referenced this pull request Dec 4, 2023
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wiring diagram imrovements
2 participants