Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: move SignedStateFileManagerWiring into PlatformWiring #10207

Merged
merged 11 commits into from
Dec 5, 2023
Merged

feat: move SignedStateFileManagerWiring into PlatformWiring #10207

merged 11 commits into from
Dec 5, 2023

Conversation

litt3
Copy link
Contributor

@litt3 litt3 commented Nov 30, 2023

Move SignedStateFileManagerWiring into PlatformWiring
525def5 
Signed-off-by: Austin Littley <austin@swirldslabs.com>
@litt3 litt3 self-assigned this Nov 30, 2023
Normalize style
fcfa2c4 
Signed-off-by: Austin Littley <austin@swirldslabs.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 30, 2023 •
edited
Loading

Node: HAPI Test (Crypto) Results

211 tests   201 ✔️  20m 13s ⏱️
  22 suites    10 💤
  22 files        0 ❌

Results for commit 73403cb.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 30, 2023 •
edited
Loading

Node: HAPI Test (Token) Results

190 tests   188 ✔️  18m 2s ⏱️
  13 suites      2 💤
  13 files        0 ❌

Results for commit 73403cb.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 30, 2023 •
edited
Loading

Node: Unit Test Results

    2 290 files  ±0      2 290 suites  ±0   44m 54s ⏱️ + 1m 20s
118 414 tests +1  118 380 ✔️ +1  34 💤 ±0  0 ❌ ±0 
126 836 runs  +1  126 802 ✔️ +1  34 💤 ±0  0 ❌ ±0 

Results for commit 73403cb. ± Comparison against base commit d15181b.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 30, 2023 •
edited
Loading

Node: HAPI Test (Misc) Results

419 tests   313 ✔️  22m 25s ⏱️
  73 suites  106 💤
  73 files        0 ❌

Results for commit 73403cb.

♻️ This comment has been updated with latest results.

@codecov Codecov
Copy link

codecov bot commented Nov 30, 2023 •
edited
Loading

Codecov Report

Attention: 27 lines in your changes are missing coverage. Please review.

Comparison is base (3b0ea4f) 63.51% compared to head (73403cb) 63.54%.
Report is 2 commits behind head on develop.

Files Patch % Lines
...va/com/swirlds/platform/wiring/PlatformWiring.java 63.41% 15 Missing ⚠️
...ain/java/com/swirlds/platform/SwirldsPlatform.java 0.00% 10 Missing ⚠️
...wirlds/common/config/PlatformSchedulersConfig.java 0.00% 1 Missing ⚠️
.../platform/wiring/SignedStateFileManagerWiring.java 85.71% 1 Missing ⚠️
Additional details and impacted files 
@@              Coverage Diff              @@
##             develop   #10207      +/-   ##
=============================================
+ Coverage      63.51%   63.54%   +0.03%     
- Complexity     30953    30971      +18     
=============================================
  Files           3337     3337              
  Lines         134351   134397      +46     
  Branches       13965    13965              
=============================================
+ Hits           85334    85407      +73     
+ Misses         45661    45641      -20     
+ Partials        3356     3349       -7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 30, 2023 •
edited
Loading

Node: E2E Test Results

    1 files      1 suites   29m 52s ⏱️
311 tests 311 ✔️ 0 💤 0 ❌
333 runs  333 ✔️ 0 💤 0 ❌

Results for commit 73403cb.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 30, 2023 •
edited
Loading

Node: HAPI Test (Time Consuming) Results

21 tests     9 ✔️  26m 0s ⏱️
  2 suites  12 💤
  2 files      0 ❌

Results for commit 73403cb.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 30, 2023 •
edited
Loading

Node: Integration Test Results

279 tests   279 ✔️  27m 55s ⏱️
    5 suites      0 💤
    5 files        0 ❌

Results for commit 73403cb.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 30, 2023 •
edited
Loading

Node: HAPI Test (Smart Contract) Results

405 tests   325 ✔️  49m 49s ⏱️
  56 suites    80 💤
  56 files        0 ❌

Results for commit 73403cb.

♻️ This comment has been updated with latest results.

@litt3 litt3 added this to the v0.46 milestone Dec 4, 2023
Enable thread metrics for state saving
f7a095c 
Signed-off-by: Austin Littley <austin@swirldslabs.com>
@litt3 litt3 marked this pull request as ready for review December 4, 2023 19:13
@litt3 litt3 requested review from a team as code owners December 4, 2023 19:13
lpetrovic05
lpetrovic05 previously approved these changes Dec 5, 2023
View reviewed changes
Austin Littley added 2 commits December 5, 2023 09:48
Merge branch 'develop' into 10204-combine-wiring
4c72a85
Respond to PR comments
12bbf32 
Signed-off-by: Austin Littley <austin@swirldslabs.com>
Austin Littley and others added 2 commits December 5, 2023 12:17
Fix unit test
940dce8 
Signed-off-by: Austin Littley <austin@swirldslabs.com>
@litt3
Merge branch 'develop' into 10204-combine-wiring
b583883
@litt3 litt3 merged commit 968068f into develop Dec 5, 2023
23 of 24 checks passed
@litt3 litt3 deleted the 10204-combine-wiring branch December 5, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edward-swirldslabs edward-swirldslabs edward-swirldslabs approved these changes

@cody-littley cody-littley cody-littley approved these changes

@mxtartaglia-sl mxtartaglia-sl Awaiting requested review from mxtartaglia-sl mxtartaglia-sl was automatically assigned from hashgraph/platform-base

@anthony-swirldslabs anthony-swirldslabs Awaiting requested review from anthony-swirldslabs anthony-swirldslabs was automatically assigned from hashgraph/platform-data

@lpetrovic05 lpetrovic05 Awaiting requested review from lpetrovic05

Assignees

@litt3 litt3

Labels
None yet
Projects
None yet
Milestone
v0.46
Development

Successfully merging this pull request may close these issues.

Move SignedStateFileManagerWiring into PlatformWiring
4 participants
@litt3 @lpetrovic05 @cody-littley @edward-swirldslabs