Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ISS detection. #10182

Merged
merged 3 commits into from
Nov 30, 2023
Merged

Fix ISS detection. #10182

merged 3 commits into from
Nov 30, 2023

Conversation

cody-littley
Copy link
Contributor

Related to #10181

Signed-off-by: Cody Littley <cody@swirldslabs.com>
Copy link

github-actions bot commented Nov 30, 2023

Node: Unit Test Results

    2 259 files      2 259 suites   1h 24m 12s ⏱️
118 229 tests 118 195 ✔️ 34 💤 0
126 489 runs  126 455 ✔️ 34 💤 0

Results for commit 859ca78.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 30, 2023

Node: E2E Test Results

    1 files      1 suites   21m 40s ⏱️
310 tests 310 ✔️ 0 💤 0
332 runs  332 ✔️ 0 💤 0

Results for commit 859ca78.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (e69d0a9) 65.24% compared to head (859ca78) 65.24%.

Files Patch % Lines
...irlds/platform/state/iss/ConsensusHashManager.java 0.00% 4 Missing ⚠️
...rlds/common/system/events/BaseEventHashedData.java 0.00% 1 Missing ⚠️
...irlds/platform/state/signed/StartupStateUtils.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##             release/0.44   #10182      +/-   ##
==================================================
- Coverage           65.24%   65.24%   -0.01%     
+ Complexity          29615    29609       -6     
==================================================
  Files                3260     3260              
  Lines              124286   124276      -10     
  Branches            12883    12880       -3     
==================================================
- Hits                81093    81083      -10     
+ Misses              40127    40126       -1     
- Partials             3066     3067       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Nov 30, 2023

Node: Integration Test Results

280 tests   280 ✔️  32m 32s ⏱️
    5 suites      0 💤
    5 files        0

Results for commit 859ca78.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 30, 2023

Node: HAPI Test Results

1 200 tests   731 ✔️  1h 6m 56s ⏱️
   163 suites  469 💤
   163 files        0

Results for commit 859ca78.

♻️ This comment has been updated with latest results.

Signed-off-by: Cody Littley <cody@swirldslabs.com>
Signed-off-by: Cody Littley <cody@swirldslabs.com>
@poulok poulok merged commit 94d77e2 into release/0.44 Nov 30, 2023
11 of 13 checks passed
@poulok poulok deleted the 10181-44-fix-iss-detection branch November 30, 2023 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants