-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ISS detection. #10182
Merged
Merged
Fix ISS detection. #10182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cody Littley <cody@swirldslabs.com>
cody-littley
requested review from
poulok,
hendrikebbers,
artemananiev,
lpetrovic05,
litt3 and
edward-swirldslabs
November 30, 2023 00:03
edward-swirldslabs
previously approved these changes
Nov 30, 2023
platform-sdk/swirlds-common/src/main/java/com/swirlds/common/system/BasicSoftwareVersion.java
Show resolved
Hide resolved
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## release/0.44 #10182 +/- ##
==================================================
- Coverage 65.24% 65.24% -0.01%
+ Complexity 29615 29609 -6
==================================================
Files 3260 3260
Lines 124286 124276 -10
Branches 12883 12880 -3
==================================================
- Hits 81093 81083 -10
+ Misses 40127 40126 -1
- Partials 3066 3067 +1 ☔ View full report in Codecov by Sentry. |
lpetrovic05
reviewed
Nov 30, 2023
platform-sdk/swirlds-common/src/main/java/com/swirlds/common/system/BasicSoftwareVersion.java
Show resolved
Hide resolved
Signed-off-by: Cody Littley <cody@swirldslabs.com>
Signed-off-by: Cody Littley <cody@swirldslabs.com>
litt3
approved these changes
Nov 30, 2023
poulok
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #10181