feat: Implement synthetic records for immediate genesis reconnect scenario #10176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Hess <matt.hess@swirldslabs.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #10176 +/- ##
==========================================
Coverage ? 63.16%
Complexity ? 30722
==========================================
Files ? 3329
Lines ? 134059
Branches ? 13892
==========================================
Hits ? 84685
Misses ? 46031
Partials ? 3343 ☔ View full report in Codecov by Sentry. |
hedera-node/hedera-app/src/main/java/com/hedera/node/app/Hedera.java
Outdated
Show resolved
Hide resolved
tinker-michaelj
previously approved these changes
Nov 29, 2023
iwsimon
reviewed
Nov 30, 2023
.../src/main/java/com/hedera/node/app/service/token/impl/schemas/SyntheticRecordsGenerator.java
Show resolved
Hide resolved
Signed-off-by: Matt Hess <matt.hess@swirldslabs.com>
4fb7847
4b4c0e9 to
4fb7847
Compare
tinker-michaelj
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basic idea behind this PR is that the
TokenSchemaclass has been split out into two parts: the synthetic records that need to be created, and the actual creation of the accounts. TheHederaclass now has logic to determine if any synthetic records need to be generated, and if so, theSyntheticRecordsGeneratorclass will generate only the records. If applicable, these synthetic records will also be passed to the token schema class to actually create the entities in state.The modular behavior is now similar to the mono service in how it handles this scenario, but unfortunately we haven't figured out a way to test this.
Closes #9757