build: do not publish test fixtures #10147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #10147 +/- ##
==========================================
Coverage 63.13% 63.13%
+ Complexity 30700 30698 -2
==========================================
Files 3327 3327
Lines 133875 133875
Branches 13875 13875
==========================================
Hits 84523 84523
+ Misses 46022 46018 -4
- Partials 3330 3334 +4 ☔ View full report in Codecov by Sentry. |
Node: E2E Test Results 1 files ± 0 1 suites ±0 23m 21s ⏱️ + 23m 21s Results for commit 161935b. ± Comparison against base commit 0203ede. This pull request removes 1 and adds 310 tests. Note that renamed tests count towards both. |
nathanklick
approved these changes
Dec 4, 2023
mhess-swl
pushed a commit
that referenced
this pull request
Dec 4, 2023
Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
This was referenced Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
We do not have a good reason to publish them and the POM metadata is incomplete/confusing.
This PR also fixes that, if we should publish test fixtures again in the future, versions will be added to test fixture onnly dependencies.
Related issue(s):
Fixes #10143
Notes for reviewer:
Checklist