-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: More common tests moved to correct module #10133
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hendrik Ebbers <hendrik.ebbers@web.de>
Signed-off-by: Hendrik Ebbers <hendrik.ebbers@web.de>
Signed-off-by: Hendrik Ebbers <hendrik.ebbers@web.de>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #10133 +/- ##
=============================================
+ Coverage 63.13% 63.57% +0.44%
- Complexity 30698 30863 +165
=============================================
Files 3327 3321 -6
Lines 133867 133698 -169
Branches 13875 13869 -6
=============================================
+ Hits 84511 84996 +485
+ Misses 46021 45357 -664
- Partials 3335 3345 +10 ☔ View full report in Codecov by Sentry. |
hendrikebbers
requested review from
isavov,
leninmehedy,
poulok,
timo0 and
artemananiev
November 28, 2023 10:45
timo0
approved these changes
Dec 1, 2023
isavov
approved these changes
Dec 1, 2023
hendrikebbers
changed the title
More common tests moved to correct module
chore!: More common tests moved to correct module
Dec 4, 2023
lpetrovic05
approved these changes
Dec 4, 2023
jeromy-cannon
approved these changes
Dec 4, 2023
cody-littley
approved these changes
Dec 4, 2023
Why is this considered a breaking change? Is it even possible to have a test-only breaking change? |
mhess-swl
pushed a commit
that referenced
this pull request
Dec 4, 2023
Signed-off-by: Hendrik Ebbers <hendrik.ebbers@web.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #6638