Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: More common tests moved to correct module #10133

Merged
merged 3 commits into from
Dec 4, 2023

Conversation

hendrikebbers
Copy link
Member

Part of #6638

Signed-off-by: Hendrik Ebbers <hendrik.ebbers@web.de>
Signed-off-by: Hendrik Ebbers <hendrik.ebbers@web.de>
Signed-off-by: Hendrik Ebbers <hendrik.ebbers@web.de>
@hendrikebbers hendrikebbers self-assigned this Nov 28, 2023
Copy link

Node: Unit Test Results

    2 286 files  ±0      2 286 suites  ±0   47m 45s ⏱️ + 3m 36s
118 389 tests ±0  118 355 ✔️ +1  34 💤 ±0  0  - 1 
126 761 runs  ±0  126 727 ✔️ +1  34 💤 ±0  0  - 1 

Results for commit 9d48055. ± Comparison against base commit 2613f05.

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2613f05) 63.13% compared to head (9d48055) 63.57%.
Report is 35 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop   #10133      +/-   ##
=============================================
+ Coverage      63.13%   63.57%   +0.44%     
- Complexity     30698    30863     +165     
=============================================
  Files           3327     3321       -6     
  Lines         133867   133698     -169     
  Branches       13875    13869       -6     
=============================================
+ Hits           84511    84996     +485     
+ Misses         46021    45357     -664     
- Partials        3335     3345      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Node: HAPI Test (Token) Results

190 tests   188 ✔️  20m 2s ⏱️
  13 suites      2 💤
  13 files        0

Results for commit 9d48055.

Copy link

Node: HAPI Test (Crypto) Results

211 tests  ±0   201 ✔️ ±0   20m 10s ⏱️ + 1m 33s
  22 suites ±0     10 💤 ±0 
  22 files   ±0       0 ±0 

Results for commit 9d48055. ± Comparison against base commit 2613f05.

Copy link

Node: HAPI Test (Misc) Results

418 tests  ±0   284 ✔️ ±0   22m 43s ⏱️ -53s
  73 suites ±0   134 💤 ±0 
  73 files   ±0       0 ±0 

Results for commit 9d48055. ± Comparison against base commit 2613f05.

Copy link

Node: E2E Test Results

    1 files      1 suites   23m 7s ⏱️
310 tests 310 ✔️ 0 💤 0
332 runs  332 ✔️ 0 💤 0

Results for commit 9d48055.

Copy link

Node: HAPI Test (Time Consuming) Results

21 tests     9 ✔️  26m 12s ⏱️
  2 suites  12 💤
  2 files      0

Results for commit 9d48055.

Copy link

github-actions bot commented Nov 28, 2023

Node: Integration Test Results

279 tests  ±0   279 ✔️ ±0   28m 20s ⏱️ +16s
    5 suites ±0       0 💤 ±0 
    5 files   ±0       0 ±0 

Results for commit 9d48055. ± Comparison against base commit 2613f05.

♻️ This comment has been updated with latest results.

Copy link

Node: HAPI Test (Smart Contract) Results

411 tests   318 ✔️  46m 9s ⏱️
  56 suites    93 💤
  56 files        0

Results for commit 9d48055.

@hendrikebbers hendrikebbers marked this pull request as ready for review November 28, 2023 10:45
@hendrikebbers hendrikebbers requested review from a team as code owners November 28, 2023 10:45
@hendrikebbers hendrikebbers changed the title More common tests moved to correct module chore!: More common tests moved to correct module Dec 4, 2023
@cody-littley
Copy link
Contributor

chore!

Why is this considered a breaking change? Is it even possible to have a test-only breaking change?

@hendrikebbers hendrikebbers merged commit 7ac0a02 into develop Dec 4, 2023
26 of 27 checks passed
@hendrikebbers hendrikebbers deleted the common-test-to-correct-module branch December 4, 2023 15:32
mhess-swl pushed a commit that referenced this pull request Dec 4, 2023
Signed-off-by: Hendrik Ebbers <hendrik.ebbers@web.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants