Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch UncheckedIOException during PCES file copy. (#10083) #10087

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

cody-littley
Copy link
Contributor

Closes #10082

Signed-off-by: Cody Littley <cody@swirldslabs.com>
@cody-littley cody-littley added this to the v0.44 milestone Nov 22, 2023
@cody-littley cody-littley self-assigned this Nov 22, 2023
@cody-littley cody-littley requested a review from a team as a code owner November 22, 2023 22:32
Copy link

Node: Unit Test Results

    2 259 files      2 259 suites   1h 32m 21s ⏱️
118 235 tests 118 201 ✔️ 34 💤 0
126 495 runs  126 461 ✔️ 34 💤 0

Results for commit 337a719.

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (2041571) 65.24% compared to head (337a719) 65.24%.

Files Patch % Lines
...consensus/BestEffortPreconsensusEventFileCopy.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##             release/0.44   #10087      +/-   ##
==================================================
- Coverage           65.24%   65.24%   -0.01%     
  Complexity          29613    29613              
==================================================
  Files                3260     3260              
  Lines              124282   124282              
  Branches            12881    12881              
==================================================
- Hits                81089    81085       -4     
- Misses              40127    40131       +4     
  Partials             3066     3066              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Node: E2E Test Results

    1 files      1 suites   21m 28s ⏱️
310 tests 310 ✔️ 0 💤 0
332 runs  332 ✔️ 0 💤 0

Results for commit 337a719.

Copy link

Node: Integration Test Results

280 tests   280 ✔️  32m 57s ⏱️
    5 suites      0 💤
    5 files        0

Results for commit 337a719.

@poulok poulok merged commit f6e7d7c into release/0.44 Nov 23, 2023
9 of 13 checks passed
@poulok poulok deleted the 10082-44-catch-unchecked-io branch November 23, 2023 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants