build: patch everything we use to be a real Java Module #10056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node: E2E Test Results 1 files ± 0 1 suites ±0 23m 12s ⏱️ + 23m 12s Results for commit ec1e90a. ± Comparison against base commit c71508e. This pull request removes 1 and adds 311 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
6f2fc4e to
84883a2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #10056 +/- ##
=============================================
+ Coverage 63.11% 63.13% +0.02%
+ Complexity 30722 30696 -26
=============================================
Files 3335 3327 -8
Lines 134140 133875 -265
Branches 13914 13875 -39
=============================================
- Hits 84659 84520 -139
+ Misses 46137 46018 -119
+ Partials 3344 3337 -7 ☔ View full report in Codecov by Sentry. |
7ced075 to
a39a415
Compare
jjohannes
commented
Nov 28, 2023
a39a415 to
5c5626f
Compare
Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
ac25363 to
5914e8a
Compare
Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
5914e8a to
ec1e90a
Compare
nathanklick
approved these changes
Dec 4, 2023
mhess-swl
pushed a commit
that referenced
this pull request
Dec 4, 2023
Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
module-info.failOnAutomaticModules.set(true)feature ofextra-module-infoensures that no non-module Jars can be added (without corresponding patching) in the future.java-module-dependenciesplugin allow us to remove some tweaks we had to doAgain, there are probably missing
requiresto core Java Modules in some of the patched Jars. This will be seen once we start using the Module Path at (test) runtime. This will be follow up work.Notes for reviewer:
Checklist