Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor SCRH#createContract as a TransitionLogic in terms of HederaContracts #84

Closed
tinker-michaelj opened this issue May 12, 2020 · 1 comment
Closed

Refactor SCRH#createContract as a TransitionLogic in terms of HederaContracts #84

tinker-michaelj opened this issue May 12, 2020 · 1 comment
Assignees
@tinker-michaelj

Comments

@tinker-michaelj
Copy link
Collaborator

Given an injected instance of HederaContracts, the handleTransaction logic for a ContractCreate should amount to:

  1. Construct a HederaContracts#CreationRequest from the signed txn.
  2. Invoke contracts.create(request), catching any exception.
  3. Set the transaction context status from the CreationResult/exception.
@tinker-michaelj tinker-michaelj self-assigned this May 12, 2020
ljianghedera pushed a commit that referenced this issue Aug 1, 2020
#146, #84: Change the json cfg files to have experimentConfig section…
f1eba62 
… with delay values that were hardwired in testConfig earlier
ljianghedera pushed a commit that referenced this issue Aug 1, 2020
#146, #84: restore the experimentConfig changes lost during reversion
88c6ec6
@tinker-michaelj tinker-michaelj mentioned this issue Jan 3, 2021
Merged
@tinker-michaelj
Copy link
Collaborator Author

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tinker-michaelj tinker-michaelj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tinker-michaelj