Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ScImpl#contractGetBytecode as an AnswerService in terms of HederaContracts #78

Closed
tinker-michaelj opened this issue May 12, 2020 · 0 comments · Fixed by #908
Closed

Refactor ScImpl#contractGetBytecode as an AnswerService in terms of HederaContracts #78

tinker-michaelj opened this issue May 12, 2020 · 0 comments · Fixed by #908
Assignees
@tinker-michaelj

Comments

@tinker-michaelj
Copy link
Collaborator

Given an injected instance of HederaContracts, the query-answering logic for a valid ANSWER_ONLY version of ContractGetBytecode should amount to:

  1. Extract the target contract from the query.
  2. Invoke contracts.getBytecode(id), catching any exception.
  3. Provide a response from the recoverd bytes/exception.
@tinker-michaelj tinker-michaelj self-assigned this May 12, 2020
ljianghedera pushed a commit that referenced this issue Aug 1, 2020
@rgsearcy
Merge pull request #78 from swirlds/00077-D-Fix-Cron-Issue
09d56b4 
Change the ssh-agent portion of the script to properly work when cron…
@tinker-michaelj tinker-michaelj mentioned this issue Jan 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tinker-michaelj tinker-michaelj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reduce duplication in Smart Contract Service hashgraph/hedera-services
1 participant
@tinker-michaelj