Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable SC ability to transfer money into account protected by receiverSigRequired #41

Closed
tinker-michaelj opened this issue May 12, 2020 · 0 comments
Closed

Disable SC ability to transfer money into account protected by receiverSigRequired #41

tinker-michaelj opened this issue May 12, 2020 · 0 comments
Assignees
@tinker-michaelj @anighanta
Labels
Bug An error that causes the feature to behave differently than what was expected based on design. P1 High priority issue, which must be completed in the milestone otherwise the release is at risk.

Comments

@tinker-michaelj
Copy link
Collaborator

Summary of the defect
The receiverSigRequired setting on an account is ignored for transfers triggered by a Solidity transaction.

Suggested resolution
Track the non-contract addresses that receive hbar during a Solidity execution; if any have receiverSigRequired, and the governing transaction is missing an active signature from the associated Key, revert the Solidity transaction.
@tinker-michaelj tinker-michaelj added Bug An error that causes the feature to behave differently than what was expected based on design. P1 High priority issue, which must be completed in the milestone otherwise the release is at risk. labels May 12, 2020
lukelee-sl pushed a commit that referenced this issue Mar 31, 2023
@tinker-michaelj @lukelee-sl
Fix AccountID's generated from missing EVM addresses (#41)
0b74532 
* Ensure a missing EVM address is preserved both for use in synth txn bodies and lazy creation

Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>

* Add comment

Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>

---------

Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tinker-michaelj tinker-michaelj

@anighanta anighanta

Labels
Bug An error that causes the feature to behave differently than what was expected based on design. P1 High priority issue, which must be completed in the milestone otherwise the release is at risk.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tinker-michaelj @anighanta