Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review what smart contract properties should be inherited when one contract is creating another contract. #31

Closed
5 tasks done
tinker-michaelj opened this issue May 12, 2020 · 0 comments
Closed
5 tasks done

Review what smart contract properties should be inherited when one contract is creating another contract. #31

tinker-michaelj opened this issue May 12, 2020 · 0 comments
Assignees
@noshmody @steven-sheehy @donaldthibeau @qnswirlds @tinker-michaelj
Labels
Impact Potentially impacts SDK, clients, docs and/or users. P1 High priority issue, which must be completed in the milestone otherwise the release is at risk. Release Note Issues which need a release note created.

Comments

@tinker-michaelj
Copy link
Collaborator

Summary

First, when a "parent" contract creates a "child" contract using the Solidity new keyword, propagate the parent contract properties to the child, including the:

  • expiration
  • autorenew period
  • admin key
  • memo field
  • proxy account id

Second, extend the TransactionRecord protobuf to support a list of created contract ids.

Suggested resolution

  • Scan the address: list[address] map of creations in the EVM ProgramResult upon successful execution of a Solidity transaction and customize all new accounts with the parent properties.
  • Add the creations to the TransactionContext for later storage in the record.
@tinker-michaelj tinker-michaelj added Impact Potentially impacts SDK, clients, docs and/or users. P1 High priority issue, which must be completed in the milestone otherwise the release is at risk. Release Note Issues which need a release note created. labels May 12, 2020
tinker-michaelj pushed a commit that referenced this issue Sep 16, 2020
@Daniel-K-Ivanov
Merge pull request #31 from LimeChain/bdd-tests-token-name-wipe
18dd9be 
Tests: BDD Tests for Token name and Token wipe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@noshmody noshmody

@steven-sheehy steven-sheehy

@donaldthibeau donaldthibeau

@qnswirlds qnswirlds

@tinker-michaelj tinker-michaelj

Labels
Impact Potentially impacts SDK, clients, docs and/or users. P1 High priority issue, which must be completed in the milestone otherwise the release is at risk. Release Note Issues which need a release note created.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@noshmody @steven-sheehy @donaldthibeau @qnswirlds @tinker-michaelj