Skip to content

Commit

Permalink
Minor wording changes/improved variable name in ThrottleDefsManager
Browse files Browse the repository at this point in the history
Signed-off-by: tinker-michaelj <michael.tinker@hedera.com>
  • Loading branch information
tinker-michaelj committed Apr 5, 2021
1 parent 535d4fc commit 6c31496
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
8 changes: 4 additions & 4 deletions docs/services-configuration.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ each kind of properties as described below.
## Overriding bootstrap and static properties

If a _data/config/bootstrap.properties_ file is present when the network
first starts (that is, at genesis), then the contents of this file
starts (including at genesis), then the contents of this file
override the defaults for any bootstrap or static property listed.
For example, when starting a network for integration testing, the
Services team often wants more permissive throttles than the
Expand All @@ -47,9 +47,9 @@ This causes the throttling definitions file `0.0.123` to be initialized
with a [genesis state](../hedera-node/src/main/resources/throttles-dev.json) that allows higher tps.

Of course, if a _data/config/bootstrap.properties_ is used, it **must**
be present on all nodes! Otherwise the genesis state would be
inconsistent across the network. This makes the file less attractive
for production use cases.
be present on all nodes! Otherwise the state would be inconsistent
across the network. This makes the file less attractive for production
use cases.

## Overriding dynamic properties

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -90,13 +90,13 @@ public OptionalInt priorityForCandidate(FileID id) {

@Override
public Map.Entry<ResponseCodeEnum, Boolean> preUpdate(FileID id, byte[] newContents) {
Optional<ThrottleDefinitions> rates = uncheckedParseFrom(newContents);
if (rates.isEmpty()) {
Optional<ThrottleDefinitions> newThrottles = uncheckedParseFrom(newContents);
if (newThrottles.isEmpty()) {
return UNPARSEABLE_VERDICT;
}

var n = addressBook.get().getSize();
var proto = rates.get();
var proto = newThrottles.get();
var defs = toPojo.apply(proto);
Set<HederaFunctionality> customizedOps = new HashSet<>();
for (var bucket : defs.getBuckets()) {
Expand Down

0 comments on commit 6c31496

Please sign in to comment.