Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add configurable commit hash for JS builds. #2751

Merged
merged 11 commits into from
Jan 8, 2025

Conversation

gsstoykov
Copy link
Contributor

Description:
This PR introduces a new variable in the Taskfile configuration in order to point to a specific services proto version. SDK should never hold outdated definitions of proto domain.

Related issue(s):

Fixes #2747

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
@gsstoykov gsstoykov added the enhancement New feature or request label Jan 7, 2025
@gsstoykov gsstoykov self-assigned this Jan 7, 2025
@gsstoykov gsstoykov linked an issue Jan 7, 2025 that may be closed by this pull request
Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
@gsstoykov gsstoykov marked this pull request as ready for review January 7, 2025 13:09
@gsstoykov gsstoykov requested review from a team as code owners January 7, 2025 13:09
@gsstoykov gsstoykov requested a review from rwalworth January 7, 2025 13:09
Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
Copy link

sonarqubecloud bot commented Jan 7, 2025

Copy link
Contributor

@agadzhalov agadzhalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gsstoykov gsstoykov merged commit 1407140 into main Jan 8, 2025
14 checks passed
@gsstoykov gsstoykov deleted the 02747-fix-and-enhance-update-task-in-taskfile branch January 8, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix and enhance update task in Taskfile
2 participants