Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: locale direction #385

Merged
merged 1 commit into from
Jan 11, 2024
Merged

fix: locale direction #385

merged 1 commit into from
Jan 11, 2024

Conversation

R894
Copy link
Collaborator

@R894 R894 commented Jan 9, 2024

Description

Closes #331

screenshots

image

image

@R894 R894 requested a review from NoamGaash as a code owner January 9, 2024 21:52
@R894 R894 requested a review from shootermv January 9, 2024 21:53
Copy link
Member

@NoamGaash NoamGaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! can you attach a hebrew screenshot as well?

@R894
Copy link
Collaborator Author

R894 commented Jan 10, 2024

I've updated the original post with a Hebrew screenshot @NoamGaash

Copy link
Member

@NoamGaash NoamGaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Thanks

@NoamGaash NoamGaash merged commit ee93af2 into hasadna:main Jan 11, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support locale direction
2 participants