-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Sys trait for swapping out system #109
base: master
Are you sure you want to change the base?
Conversation
I like this but can we adjust the presentation a bit? I'd consider this a feature for advanced users. So we should move the README example into the generated rustdocs. Additionally let's not flatten the |
Also if you haven't already you should use your new trait in a proof of concept implementation for your own use case. It'd be a shame if we needed to revise the trait after this was already published. |
…sable PATHEXT caching
Yes, that would be good. I'll look into doing that later. Going to convert this PR to draft until I find the time. |
Creates a
Sys
trait and puts any system related functionality behind it.This has several benefits:
RealSys
implementation).env_home
,rustix
, andwinsafe
if they already have code or other dependencies for doing this.which::Sys
implementation.