Skip to content

Commit

Permalink
Remove Poety use from netchecks lib (#300)
Browse files Browse the repository at this point in the history
* bump timeout

* bump++

* force zero return

* debug job

* remove poetry dep
  • Loading branch information
TheDen authored Jan 31, 2025
1 parent 267b573 commit 320084e
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 7 deletions.
10 changes: 4 additions & 6 deletions operator/netchecks_operator/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -709,12 +709,10 @@ def create_job_spec(
pass

command = [
"poetry",
"run",
"netcheck",
"run",
"--config",
"/netcheck/config.json",
"netcheck",
"run",
"--config",
"/netcheck/config.json",
]

if disable_redaction:
Expand Down
20 changes: 19 additions & 1 deletion operator/tests/test_dns_default_cluster.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,27 @@ def test_dns_check_with_installed_operator(netchecks, k8s_namespace, test_file_p
break
time.sleep(1.5**i)

subprocess.run(
f"kubectl wait Job/{name} -n {k8s_namespace} --for condition=complete --timeout=120s || true",
shell=True,
check=True,
)

# Wait for the job to complete
subprocess.run(
f"kubectl wait Job/{name} -n {k8s_namespace} --for condition=complete --timeout=120s",
f"kubectl logs -n {k8s_namespace} job/{name} -f",
shell=True,
check=True,
)

subprocess.run(
f"kubectl describe job/{name} -n {k8s_namespace}",
shell=True,
check=True,
)

subprocess.run(
f"kubectl get events -n {k8s_namespace}",
shell=True,
check=True,
)
Expand Down

0 comments on commit 320084e

Please sign in to comment.