Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cleanup to be consistent across node releases #129

Merged
merged 1 commit into from
Aug 25, 2020
Merged

Fix cleanup to be consistent across node releases #129

merged 1 commit into from
Aug 25, 2020

Conversation

kanongil
Copy link
Contributor

This is done to fix the issue in hapijs/hapi#4149.

@kanongil kanongil added the bug Bug or defect label Aug 25, 2020
This was referenced Aug 25, 2020
Merged
Closed
@cjihrig cjihrig merged commit 50ceba6 into hapijs:master Aug 25, 2020
@cjihrig
Copy link
Contributor

cjihrig commented Aug 25, 2020

I'll do a patch release right now.

@cjihrig
Copy link
Contributor

cjihrig commented Aug 25, 2020

v5.0.2 has been released with this change.

@cjihrig cjihrig added this to the 5.0.2 milestone Aug 25, 2020
@devinivy devinivy mentioned this pull request Aug 25, 2020
Closed
This was referenced Aug 26, 2020
Merged
Merged
devinivy pushed a commit that referenced this pull request Sep 2, 2020
@kanongil
Another attempt at #129 (#133)
e84429e 
* Improved testing of request stream lifetime

* Fix cleanup to be consistent across node releases

Take 2, with extra close emit, and additional testing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@devinivy devinivy devinivy approved these changes

Assignees
No one assigned
Labels
bug Bug or defect
Projects
None yet
Milestone
5.0.2
Development

Successfully merging this pull request may close these issues.
3 participants
@kanongil @cjihrig @devinivy