Add support for custom icons by id in blender #55
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Blender apart from the existing icons which can be referenced by name, they can also be custom ones created which can be referenced by id
This changes validates the menu icon data type and properly attempts to set it by the correct argument
So when setting up the menu items, we can have a full file path as the icon key value
This is a simplified implementation that leaves the handling of the icons to the dev configuring the menus, particularly if its needed to reuse icons in other places too, but we can also include the full icon setup and check if the icon value is a file path and in such case create the icon and use it directly, open for suggestions
:)