Unreal context menus #48

JLHayde · 2023-07-17T13:23:28Z

An update that adds an option to setup menus in the context menu of an asset

Adding option to unreal app to use asset context menu

hannesdelbeke

This looks really cool, I do have some concerns regarding this feature only wokring in Unreal.
Ideally the unimenu interface for all apps only adds new args if these are supported in all, or most apps. (see the features overview)
Let's see if we can make this feature a bit more generic.

unimenu/apps/unreal.py

unimenu/apps/_abstract.py

exposed some flags to customise where the menu can be placed

unimenu/apps/unreal.py

Can now add seperatore Can now add icons

…l_context_menus

hannesdelbeke

when testing out the sample code on your branch, i get an error

import unreal_context_menu

LogPython: Error: Traceback (most recent call last):
LogPython: Error:   File "<string>", line 1, in <module>
LogPython: Error:   File "C:\Users\hanne\OneDrive\Documents\Unreal Projects\MyProject\Content\Python\Lib\site-packages\shiboken2\files.dir\shibokensupport\__feature__.py", line 142, in _import
LogPython: Error:     return original_import(name, *args, **kwargs)
LogPython: Error:   File "C:\Users\hanne\OneDrive\Documents\Unreal Projects\MyProject\Content\Python\Lib\site-packages\unreal_context_menu.py", line 72, in <module>
LogPython: Error:     app_node = node.setup(backlink=False)
LogPython: Error:   File "C:\Users\hanne\OneDrive\Documents\Unreal Projects\MyProject\Content\Python\Lib\site-packages\unimenu\apps\unreal.py", line 26, in setup
LogPython: Error:     super().setup(parent_app_node=parent_app_node, backlink=backlink)
LogPython: Error:   File "C:\Users\hanne\OneDrive\Documents\Unreal Projects\MyProject\Content\Python\Lib\site-packages\unimenu\apps\_abstract.py", line 214, in setup
LogPython: Error:     self.app_node = self._setup_sub_menu(parent_app_node=parent_app_node)
LogPython: Error:   File "C:\Users\hanne\OneDrive\Documents\Unreal Projects\MyProject\Content\Python\Lib\site-packages\unimenu\apps\unreal.py", line 40, in _setup_sub_menu
LogPython: Error:     return parent_app_node.add_sub_menu(
LogPython: Error: AttributeError: 'NoneType' object has no attribute 'add_sub_menu'

JLHayde · 2023-07-18T09:47:29Z

when testing out the sample code on your branch, i get an error
...

I've just tested on a couple projects, and also tested with the branch pulled from git and haven't got the error.
which UE version are you using? I'm currently on 5.2

hannesdelbeke · 2023-07-18T09:56:35Z

I've just tested on a couple projects, and also tested with the branch pulled from git and haven't got the error. which UE version are you using? I'm currently on 5.2

i'm on 5.0.2. i tested another sample demo any_dcc_test and that one works (but with a bug #50)

JLHayde · 2023-07-18T15:05:06Z

i've run a the sample on another machine and with 5.0.3 and I cant seem to get the error

The only thing that could be different is that your running from ..../Unreal Projects\MyProject\Content\Python\Lib\site-packages and in my launcher I'm adding to PYTHONPATH. but that shouldn't make a difference

Edit:
i have manged to get the error by changing 'root_menu' to something like ContentBrowser.AssetContextMenu.Sta
in the sample. this would be correct as that menu doesn't exists. maybe this menu has not been registered at the time the the sample was run?

hannesdelbeke · 2023-07-19T15:51:31Z

~~just retried today and works now 🤷~~
double checked that wasn't on your branch. (it added the menu to the top menu)
after swapping to yours it breaks again. same error
got it to work, needed to go to a folder with assets, and right click the menu before running the script. this ensures the root menu exists.
now it runs correctly and adds the menu to the right click menu.

might have to look at extend_menu https://docs.unrealengine.com/4.26/en-US/PythonAPI/class/ToolMenus.html#unreal.ToolMenus it can handle cases where the menu doesn't exist yet.

hannesdelbeke · 2023-07-19T22:10:26Z

FYI, i suggest to split this up in separate PRs, i noticed you also integrated icon and separator.
It's easier for me to review 1 feature at a time.
deffo want to integrate this though

with the parentpath change, i think we don't need the rootmeno / context menu change from this PR anymore.

JLHayde · 2023-07-20T12:30:17Z

Sure ill make another pr with just the icons.

Its strange that it does not work without opening the context menu first. I'm running the code on init_unreal.py so its happening at the earliest it can. I'll look into the extend method. and also exclude the separator and icon changes from this pull

hannesdelbeke · 2023-07-20T12:37:16Z

ye by default unreal starts in site package folder, which has no assets.
the context menu doesn't has the section we are adding to either

what is still left from this PR? since we can use parent_path we dont need root menu anymore
and you ll move icons and separator to a new PR.

JLHayde · 2023-07-20T12:39:49Z

The 'menu_section' kwarg will be needed so the user can specify in the which area of the context menu to put the menu/action

hannesdelbeke · 2023-07-20T12:41:11Z

The 'menu_section' kwarg will be needed so the user can specify in the which area of the context menu to put the menu/action

Ah yes, that goes together with the separator I believe

set the target_section_name on the node .data so were not doing check on each add method excluded icon and seperator logic. Updated sample to reflect these changes

…_menus # Conflicts: # dev/unimenu_samples/menu_screen_unreal_context.png # dev/unimenu_samples/unreal_context_menu.py # unimenu/apps/unreal.py

…_menus

JLHayde · 2023-07-24T08:56:45Z

Pulled your latest changes and now set the menu_section in data from the kwarg. so this can be re-used later in the icons and separator fix

dev/unimenu_samples/menu_screen_unreal_context.png

unimenu/apps/unreal.py

…rs functions directly, if explicitly stated.

…_menus # Conflicts: # unimenu/apps/unreal.py

dev/unimenu_samples/unreal_context_menu.py

dev/unimenu_samples/any_dcc_test.py

JLHayde and others added 3 commits July 17, 2023 12:27

Added Context arg to the main node,

52369f8

Adding option to unreal app to use asset context menu

Merge branch 'hannesdelbeke:main' into unreal_context_menus

c984a98

updated sample text

a381a0e

hannesdelbeke requested changes Jul 17, 2023

View reviewed changes

unimenu/apps/unreal.py Outdated Show resolved Hide resolved

unimenu/apps/_abstract.py Outdated Show resolved Hide resolved

JLHayde added 3 commits July 17, 2023 15:16

Removed context menu argument

8829417

isolated context logic to just the unreal app

3f51e98

exposed some flags to customise where the menu can be placed

updated string format

74e01e7

JLHayde commented Jul 17, 2023

View reviewed changes

unimenu/apps/unreal.py Outdated Show resolved Hide resolved

JLHayde commented Jul 17, 2023

View reviewed changes

unimenu/apps/unreal.py Outdated Show resolved Hide resolved

JLHayde added 4 commits July 17, 2023 17:48

Set Section names on items and seperators

cd5dc91

Can now add seperatore Can now add icons

Set Section names on items and seperators

a63c225

Can now add seperatore Can now add icons

Merge remote-tracking branch 'origin/unreal_context_menus' into unrea…

d13314c

…l_context_menus

did not mean to change that

4084a61

JLHayde requested a review from hannesdelbeke July 17, 2023 17:00

hannesdelbeke requested changes Jul 18, 2023

View reviewed changes

updating sample

3e90aa1

hannesdelbeke added the unreal label Jul 20, 2023

JLHayde added 4 commits July 20, 2023 14:13

Removed root_menu kwarg in favour of parent_path

707078a

set the target_section_name on the node .data so were not doing check on each add method excluded icon and seperator logic. Updated sample to reflect these changes

Merge branch 'main' of github.com:JLHayde/unimenu into unreal_context…

46730e4

…_menus # Conflicts: # dev/unimenu_samples/menu_screen_unreal_context.png # dev/unimenu_samples/unreal_context_menu.py # unimenu/apps/unreal.py

section change

d66954f

Merge branch 'main' of github.com:JLHayde/unimenu into unreal_context…

5b6267c

…_menus

JLHayde added 2 commits July 24, 2023 09:18

reset test

ceb18aa

reset test

3c66b01

JLHayde requested a review from hannesdelbeke July 24, 2023 08:54

hannesdelbeke requested changes Jul 24, 2023

View reviewed changes

dev/unimenu_samples/menu_screen_unreal_context.png Outdated Show resolved Hide resolved

unimenu/apps/unreal.py Outdated Show resolved Hide resolved

unimenu/apps/unreal.py Outdated Show resolved Hide resolved

unimenu/apps/unreal.py Outdated Show resolved Hide resolved

JLHayde added 3 commits July 24, 2023 12:09

kwargs can now override args for the unreal menus, items and separato…

33beb2a

…rs functions directly, if explicitly stated.

Merge branch 'main' of github.com:JLHayde/unimenu into unreal_context…

9134535

…_menus # Conflicts: # unimenu/apps/unreal.py

resized image

a83e726

hannesdelbeke requested changes Jul 24, 2023

View reviewed changes

dev/unimenu_samples/unreal_context_menu.py Outdated Show resolved Hide resolved

hannesdelbeke requested changes Jul 24, 2023

View reviewed changes

dev/unimenu_samples/any_dcc_test.py Outdated Show resolved Hide resolved

JLHayde added 2 commits July 24, 2023 14:48

removed random line

152af6f

adjusted the command to run from the samples package

5bde8f3

hannesdelbeke merged commit 30bc0ee into hannesdelbeke:main Jul 24, 2023

hannesdelbeke mentioned this pull request Mar 20, 2024

Append Unreal ContentBrowser Folder Context Menu? #59

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Unreal context menus #48

Unreal context menus #48

JLHayde commented Jul 17, 2023 •

edited

Loading

hannesdelbeke left a comment •

edited

Loading

hannesdelbeke left a comment

JLHayde commented Jul 18, 2023 •

edited by hannesdelbeke

Loading

hannesdelbeke commented Jul 18, 2023 •

edited

Loading

JLHayde commented Jul 18, 2023 •

edited

Loading

hannesdelbeke commented Jul 19, 2023 •

edited

Loading

hannesdelbeke commented Jul 19, 2023 •

edited

Loading

JLHayde commented Jul 20, 2023

hannesdelbeke commented Jul 20, 2023

JLHayde commented Jul 20, 2023

hannesdelbeke commented Jul 20, 2023

JLHayde commented Jul 24, 2023

Unreal context menus #48

Unreal context menus #48

Conversation

JLHayde commented Jul 17, 2023 • edited Loading

hannesdelbeke left a comment • edited Loading

Choose a reason for hiding this comment

hannesdelbeke left a comment

Choose a reason for hiding this comment

JLHayde commented Jul 18, 2023 • edited by hannesdelbeke Loading

hannesdelbeke commented Jul 18, 2023 • edited Loading

JLHayde commented Jul 18, 2023 • edited Loading

hannesdelbeke commented Jul 19, 2023 • edited Loading

hannesdelbeke commented Jul 19, 2023 • edited Loading

JLHayde commented Jul 20, 2023

hannesdelbeke commented Jul 20, 2023

JLHayde commented Jul 20, 2023

hannesdelbeke commented Jul 20, 2023

JLHayde commented Jul 24, 2023

JLHayde commented Jul 17, 2023 •

edited

Loading

hannesdelbeke left a comment •

edited

Loading

JLHayde commented Jul 18, 2023 •

edited by hannesdelbeke

Loading

hannesdelbeke commented Jul 18, 2023 •

edited

Loading

JLHayde commented Jul 18, 2023 •

edited

Loading

hannesdelbeke commented Jul 19, 2023 •

edited

Loading

hannesdelbeke commented Jul 19, 2023 •

edited

Loading