Provide example of keyword/type applicability. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The word "applicability" is a good name for the key concept of this section. The title feels rather vague otherwise. Make clear that this is a natural consequence of keyword independence, which is explained in the immediately previous section. Otherwise, having a section about this makes it sound like its own special case. Use "multipleOf" to show why this is an essential behavior. When you need to use a type-specific keyword, and the negation of a keyword specific to the same type, it only works because type is not automatically constrained. I used "multipleOf" because (unlike "maxLength"), you cannot eliminate the use of "not" by changing keywords (to "minLength"). There is no other way in JSON schema to express not being a multiple of something.
|
After discussion, it's clear that this is not the right approach. |
handrews
added a commit
that referenced
this pull request
Nov 1, 2017
Better explanation of the concerns around and possible future direction of $schema usage. Also add an XML comment to remind us of the most notable concern, so we can skip the whole thing where we forget about it and then argue about it until we work it out again. Which of course has never happened...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The word "applicability" is a good name for the key concept of this
section. The title feels rather vague otherwise.
Make clear that this is a natural consequence of keyword independence,
which is explained in the immediately previous section. Otherwise,
having a section about this makes it sound like its own special case.
Use "multipleOf" to show why this is an essential behavior. When you
need to use a type-specific keyword, and the negation of a keyword
specific to the same type, it only works because type is not automatically
constrained.
I used "multipleOf" because (unlike "maxLength"), you cannot eliminate
the use of "not" by changing keywords (to "minLength"). There is no
other way in JSON schema to express not being a multiple of something.