"exit 1" breaks ones code #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| rescue Beanstalk::NotConnected => e | ||
| failed_connection(e) | ||
| rescue SystemExit | ||
| raise |
There was a problem hiding this comment.
Don't delete this rescue SystemExit block. It prevents SystemExit from being handled and swallowed by the rescue block just below.
There was a problem hiding this comment.
Also don't delete the rescue Beanstalk::NotConnected block on line 91, for the same reason. Instead, replace failed_connection(e) with raise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please do not swallow exceptions, and do not exit without my consent.
I simpĺy changed the code to let the exception bubble up.