Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor app-download hook to support binding #7

Merged
merged 1 commit into from
Sep 8, 2023
Merged

feat: refactor app-download hook to support binding #7

merged 1 commit into from
Sep 8, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Sep 7, 2023

  1. 支持从应用市场强制安装(绑定已有插件或者主题)。
  2. 支持从 Release 下载不同的版本。

/kind feature

Fixes #5

可测试 JAR 包:https://github.com/halo-dev/plugin-app-store/actions/runs/6106001042

需要测试:

  1. 从本地安装若干主题和插件,然后尝试从应用市场重新安装,观察是否可以绑定。
  2. 测试从应用市场全新安装主题或者插件,以及更新主题和插件。
  3. 测试从应用详情的 Release 页面下载不同的版本。
None

Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added kind/feature Categorizes issue or PR as related to a new feature. release-note-none Denotes a PR that doesn't merit a release note. labels Sep 7, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and JohnNiang September 7, 2023 08:33
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works very well.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Sep 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2023
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2023
@ruibaby ruibaby merged commit 0ca9ff8 into halo-dev:main Sep 8, 2023
@ruibaby ruibaby deleted the refactor/download branch September 8, 2023 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

从 Releases 列表下载旧版本的应用还是会下载最新的版本
3 participants