refactor: app version requires check #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Wang <i@ryanc.cc>
guqing
reviewed
Sep 26, 2023
| * @param requires - The required version range. | ||
| * @returns A boolean indicating whether the version satisfies the required range. | ||
| */ | ||
| export function satisfiesRequires(version?: string, requires?: string): boolean { |
There was a problem hiding this comment.
There was a problem hiding this comment.
已添加，但目前没有 CI 用来跑单元测试，稍后我将添加一个。
There was a problem hiding this comment.
先手动在本地运行 pnpm test:unit 吧，CI 放到后面的 PR。
Signed-off-by: Ryan Wang <i@ryanc.cc>
guqing
reviewed
Sep 27, 2023
Co-authored-by: guqing <38999863+guqing@users.noreply.github.com>
Signed-off-by: Ryan Wang <i@ryanc.cc>
guqing
approved these changes
Sep 27, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing, JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
基于 semver 封装新的版本范围检查方法，兼容 Halo 的规则。
Fixes #38
/kind improvement